Add linux/arm64 targets #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
409ba6d to
a147938
Compare
joshwlewis
approved these changes
Apr 25, 2024
2db2178 to
59cfa15
Compare
a147938 to
891b6b7
Compare
891b6b7 to
5d7e919
Compare
31565e6 to
566cf5f
Compare
|
I've added changelog entries as well as targets for I've removed the "skip changelog" label, and requested another review as there are changes to several files since this was initially approved by @joshwlewis - so maybe just add a 👍 if that all looks good before I merge it? :) |
This was referenced May 9, 2024
Merged
Merged
Merged
colincasey
pushed a commit
that referenced
this pull request
May 10, 2024
## heroku/nodejs ### Added - Support for `arm64` and multi-arch images. ([#815](#815)) ### Changed - Updated `heroku/nodejs-corepack` to `3.1.0`. - Updated `heroku/nodejs-engine` to `3.1.0`. - Updated `heroku/nodejs-npm-engine` to `3.1.0`. - Updated `heroku/nodejs-npm-install` to `3.1.0`. - Updated `heroku/nodejs-pnpm-engine` to `3.1.0`. - Updated `heroku/nodejs-pnpm-install` to `3.1.0`. - Updated `heroku/nodejs-yarn` to `3.1.0`. ## heroku/nodejs-corepack ### Added - Support for `arm64` and multi-arch images. ([#815](#815)) ## heroku/nodejs-engine ### Added - Support for `arm64` and multi-arch images. ([#815](#815)) ## heroku/nodejs-function ### Changed - Updated `heroku/nodejs-engine` to `3.1.0`. - Updated `heroku/nodejs-function-invoker` to `3.1.0`. - Updated `heroku/nodejs-npm` to `3.1.0`. ## heroku/nodejs-function-invoker ### Added - Support for `arm64` and multi-arch images. ([#815](#815)) ## heroku/nodejs-npm - No changes. ## heroku/nodejs-npm-engine ### Added - Support for `arm64` and multi-arch images. ([#815](#815)) ## heroku/nodejs-npm-install ### Added - Support for `arm64` and multi-arch images. ([#815](#815)) ## heroku/nodejs-pnpm-engine ### Added - Support for `arm64` and multi-arch images. ([#815](#815)) ## heroku/nodejs-pnpm-install ### Added - Support for `arm64` and multi-arch images. ([#815](#815)) ## heroku/nodejs-yarn ### Added - Support for `arm64` and multi-arch images. ([#815](#815)) Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
colincasey
pushed a commit
that referenced
this pull request
May 10, 2024
## heroku/nodejs ### Added - Support for `arm64` and multi-arch images. ([#815](#815)) ### Changed - Updated `heroku/nodejs-corepack` to `3.2.0`. - Updated `heroku/nodejs-engine` to `3.2.0`. - Updated `heroku/nodejs-npm-engine` to `3.2.0`. - Updated `heroku/nodejs-npm-install` to `3.2.0`. - Updated `heroku/nodejs-pnpm-engine` to `3.2.0`. - Updated `heroku/nodejs-pnpm-install` to `3.2.0`. - Updated `heroku/nodejs-yarn` to `3.2.0`. ## heroku/nodejs-corepack - No changes. ## heroku/nodejs-engine - No changes. ## heroku/nodejs-function ### Changed - Updated `heroku/nodejs-engine` to `3.2.0`. - Updated `heroku/nodejs-function-invoker` to `3.2.0`. - Updated `heroku/nodejs-npm` to `3.2.0`. ## heroku/nodejs-function-invoker - No changes. ## heroku/nodejs-npm - No changes. ## heroku/nodejs-npm-engine - No changes. ## heroku/nodejs-npm-install - No changes. ## heroku/nodejs-pnpm-engine - No changes. ## heroku/nodejs-pnpm-install - No changes. ## heroku/nodejs-yarn - No changes. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds the linux/arm64 targets required to package and use the various buildpacks in this repository.
It depends on #814, which introduces arm64 support through updated inventory logic and version resolution that factors in the host OS and arch.