Use artifact inventory #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8693c51 to
f0879eb
Compare
Merged
colincasey
reviewed
Apr 25, 2024
joshwlewis
approved these changes
Apr 25, 2024
2db2178 to
59cfa15
Compare
|
The PR is ready to be merged, but I'll hold off doing that until we hear back from the SA team |
22e0f81 to
47e772f
Compare
colincasey
approved these changes
Apr 30, 2024
Logic for updating this from the nodejs.org feed will be added later
Node tarballs are prefixed with the filename sans ".tar.gz", so this will allow extraction of arm64 artifacts as well.
Non-zero exit code values aren't used anywhere
Avoid dependency on an archived github action, and take the same approach as other workflows in this repository
It's clear what is happening here, so avoid assigning an "earliest version" variable/providing context for an error that'll be trivial to identify if it's ever changed.
When an error is encountered, the process will still be terminated with a non-zero exit code with adequate error information for debugging an issue written to stderr
47e772f to
d93b035
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for the artifact inventory code shared with the Go buildpack, and updates the GitHub actions for node.js to write a corresponding
inventory.tomlfile in the new format (which includes thesha256checksum that is used to verify the download, as well as the upstream URL rather than our own S3 mirrored artifact store).A few notes:
libherokubuildpackat some point.darwinartifacts and thestagingchannel releases are no longer included in the inventory.We may also want to consider migrating NPM and Yarn over to the new format at some point (so we can avoid mirroring, and simplify our codebase), but that's probably out of scope for the time being.