Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactor, mostly logs and cli flags #121

Merged
merged 13 commits into from
Oct 13, 2023
Merged

Small refactor, mostly logs and cli flags #121

merged 13 commits into from
Oct 13, 2023

Conversation

aleksasiriski
Copy link
Member

@aleksasiriski aleksasiriski commented Oct 13, 2023 •
edited
Loading

Should be merged to main after #124 (and #119)

  1. Moved all errors to .Err(err) of zerolog
  2. Removed f from Msgf part where no formatting is done
  3. Renamed config_path to more accurate data_folder
  4. Renamed log_path to more accurate log_folder
  5. Added milliseconds to places where there were only nanoseconds

@aleksasiriski aleksasiriski changed the title Small refactor Small refactor, mostly logs and cli flags Oct 13, 2023
@aleksasiriski aleksasiriski requested a review from k4lizen October 13, 2023 17:16
@aleksasiriski aleksasiriski marked this pull request as draft October 13, 2023 19:48
@aleksasiriski aleksasiriski changed the base branch from categories to linting-errors October 13, 2023 20:16
@aleksasiriski aleksasiriski marked this pull request as ready for review October 13, 2023 20:19
Base automatically changed from linting-errors to main October 13, 2023 22:11
k4lizen
k4lizen previously approved these changes Oct 13, 2023
View reviewed changes
@aleksasiriski aleksasiriski merged commit a80d805 into main Oct 13, 2023
@aleksasiriski aleksasiriski deleted the small-refactor branch October 13, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k4lizen k4lizen k4lizen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksasiriski @k4lizen