Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categories #119

Merged
merged 19 commits into from
Oct 13, 2023
Merged

Categories #119

merged 19 commits into from
Oct 13, 2023

Conversation

k4lizen
Copy link
Member

@k4lizen k4lizen commented Oct 11, 2023

  • Implemented search categories
  • Changed engine.Name enum variables to UPPERCASE, as is standard
  • Changed internal config engine map to array
  • Fixed search engine crawlers

@k4lizen k4lizen marked this pull request as draft October 12, 2023 01:51
@k4lizen k4lizen marked this pull request as ready for review October 12, 2023 21:24
@k4lizen k4lizen mentioned this pull request Oct 13, 2023
Copy link
Member

@aleksasiriski aleksasiriski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great PR, need to talk through some things before merging.

Please merge lint fixes into this

src/category/category.go Outdated Show resolved Hide resolved
src/cli/climode.go Show resolved Hide resolved
src/search/search.go Outdated Show resolved Hide resolved
src/config/load.go Outdated Show resolved Hide resolved
src/config/load.go Outdated Show resolved Hide resolved
@k4lizen k4lizen merged commit b90ac48 into main Oct 13, 2023
@k4lizen k4lizen deleted the categories branch October 13, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants