Backport of Update helm standalone TLS doc for k8s 1.22 into release/1.8.x #16043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Update helm standalone TLS doc for k8s 1.22 The `CertificateSigningRequest` for `v1beta1` API is no longer available, and now requires the `signerName` parameter. Many thanks to @DavidRBanks for the helpful notes in hashicorp/vault-helm#243 (comment) I tested this on Kubernetes 1.21 and 1.24. I also adjusted the `tr` command to work better on macOS (and still works fine on Linux).
ab62941 to
d2f6f04
Compare
swenson
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16029 to be assessed for backporting due to the inclusion of the label backport/1.8.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
The
CertificateSigningRequestforv1beta1API is no longeravailable, and now requires the
signerNameparameter.Many thanks to @DavidRBanks for the helpful notes in
hashicorp/vault-helm#243 (comment)
I tested this on Kubernetes 1.21 and 1.24. I also adjusted the
trcommand to work better on macOS (and still works fine on Linux).
Overview of commits