Update helm standalone TLS doc for k8s 1.22 #16029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `CertificateSigningRequest` for `v1beta1` API is no longer available, and now requires the `signerName` parameter. Many thanks to @DavidRBanks for the helpful notes in hashicorp/vault-helm#243 (comment) I tested this on Kubernetes 1.21 and 1.24. I also adjusted the `tr` command to work better on macOS (and still works fine on Linux).
tvoran
approved these changes
Jun 16, 2022
| export TMPDIR=/tmp | ||
|
|
||
| # CSR_NAME will be the name of our certificate signing request as seen by Kubernetes. | ||
| export CSR_NAME=vault-csr |
There was a problem hiding this comment.
May want to update the opening sentence here since it states There are three variables...
|
Thanks! |
This was referenced Jun 17, 2022
swenson
added a commit
that referenced
this pull request
Jun 17, 2022
Update helm standalone TLS doc for k8s 1.22 The `CertificateSigningRequest` for `v1beta1` API is no longer available, and now requires the `signerName` parameter. Many thanks to @DavidRBanks for the helpful notes in hashicorp/vault-helm#243 (comment) I tested this on Kubernetes 1.21 and 1.24. I also adjusted the `tr` command to work better on macOS (and still works fine on Linux).
swenson
added a commit
that referenced
this pull request
Jun 17, 2022
Update helm standalone TLS doc for k8s 1.22 The `CertificateSigningRequest` for `v1beta1` API is no longer available, and now requires the `signerName` parameter. Many thanks to @DavidRBanks for the helpful notes in hashicorp/vault-helm#243 (comment) I tested this on Kubernetes 1.21 and 1.24. I also adjusted the `tr` command to work better on macOS (and still works fine on Linux). Co-authored-by: Christopher Swenson <swenson@swenson.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CertificateSigningRequestforv1beta1API is no longeravailable, and now requires the
signerNameparameter.Many thanks to @DavidRBanks for the helpful notes in
hashicorp/vault-helm#243 (comment)
I tested this on Kubernetes 1.21 and 1.24. I also adjusted the
trcommand to work better on macOS (and still works fine on Linux).