-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading CRDs #944
Comments
I would normally recommend to render the CRDs via the However, Helm seems to have a bug that is preventing the correct rendering of CRDs from the Istio project. Even attempting this with helm CLI yelds the wrong results. I've raised the issue with Helm. Let's see how they resolve it and then I can share an example of how to implement these steps in Terraform. |
Thank you Alex. I've figured out the same, but I've been waiting for dealing with my VPC Service Control in GCP (could not get istio charts from outside GCS Bucket).So I did not even test the code:
So it would end with many bugs. I confirm your observations. I've added comment tothe related issue. |
Fixes argoproj#1430 argoproj#1468 Due to multiple instances where new/changed CRDs for argo-workflows do not get installed/updated I believe it is time to move the crds folder into the templates folder like our other helm charts. I'm aware helm 3 is supposed to handle the crds folder but it seems there are a few known issues currently [here](hashicorp/terraform-provider-helm#944), [here](helm/helm#11321) and [here](helm/helm#11330) that show that may still need some work. Signed-off-by: jmeridth <jmeridth@gmail.com>
Fixes #1430 #1468 Due to multiple instances where new/changed CRDs for argo-workflows do not get installed/updated I believe it is time to move the crds folder into the templates folder like our other helm charts. I'm aware helm 3 is supposed to handle the crds folder but it seems there are a few known issues currently [here](hashicorp/terraform-provider-helm#944), [here](helm/helm#11321) and [here](helm/helm#11330) that show that may still need some work. Signed-off-by: jmeridth <jmeridth@gmail.com> Signed-off-by: jmeridth <jmeridth@gmail.com>
@alexsomesan as far as I see there is no progress in this matter on the helm side. Do we have any workaround? |
Marking this issue as stale due to inactivity. If this issue receives no comments in the next 30 days it will automatically be closed. If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. This helps our maintainers find and focus on the active issues. Maintainers may also remove the stale label at their discretion. Thank you! |
Waiting for a resolution to helm/helm#11321 |
Marking this issue as stale due to inactivity. If this issue receives no comments in the next 30 days it will automatically be closed. If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. This helps our maintainers find and focus on the active issues. Maintainers may also remove the stale label at their discretion. Thank you! |
The problem is generic but I will use istio example just because it's my task to cope with.
Terraform version, Kubernetes provider version and Kubernetes version
Terraform configuration
not needed here
Question
I've wrapped Install Istio with Helm using the provider and now I need to upgrade not only the version Istio but most of all its CRDs. According to the istio documenations on this task I need to:
Regular upgrading with
helm_release
does not upgrade CRDs of course, so the problems stays: How to do this in fully automated environment?Do we have any pattern on this problem while it seems to be a common problem with helm?
The text was updated successfully, but these errors were encountered: