Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot launch new workflow in v.0.18.0 helm chart #1468

Closed
AndriySidliarskiy opened this issue Sep 20, 2022 · 7 comments
Closed

Cannot launch new workflow in v.0.18.0 helm chart #1468

AndriySidliarskiy opened this issue Sep 20, 2022 · 7 comments
Assignees
Labels
argo-workflows bug Something isn't working

Comments

@AndriySidliarskiy
Copy link

AndriySidliarskiy commented Sep 20, 2022

Describe the bug

Submit new workflow but nothing doing. In controller logs get request is doing but controller have Liveness probe failed: HTTP probe failed with statuscode: 500 and workflow not launching. Can you help or solve this please .

Related helm chart

argo-workflows

Helm chart version

0.18.0

To Reproduce

  1. Use argo ui
  2. Run new worklfow

Expected behavior

Run new workflow

Screenshots

image

Additional context

UPD: Solve this problem when redeploy helm chart but update to new version not working

@AndriySidliarskiy AndriySidliarskiy added the bug Something isn't working label Sep 20, 2022
@jmeridth
Copy link
Member

@AndriySidliarskiy Do you have any logs from the controller that can give us a better idea of what is going on? I'm retesting the helm chart locally right now.

@chr-b
Copy link

chr-b commented Sep 21, 2022

I am having the same issue.

The workflow controller logs shows:

W0921 08:44:42.110191       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: failed to list *v1alpha1.WorkflowArtifactGCTask: the server could not find the requested resource (get workflowartifactgctasks.argoproj.io)
E0921 08:44:42.110226       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: Failed to watch *v1alpha1.WorkflowArtifactGCTask: failed to list *v1alpha1.WorkflowArtifactGCTask: the server could not find the requested resource (get workflowartifactgctasks.argoproj.io)

This is probably related to #1430:

$ kubectl get crd
...
workfloweventbindings.argoproj.io                2021-12-20T11:05:31Z
workflows.argoproj.io                            2021-12-20T11:05:32Z
workflowtasksets.argoproj.io                     2021-12-20T11:05:32Z
workflowtemplates.argoproj.io                    2021-12-20T11:05:33Z

Those might be left over from a previous install, which means that the new CRDs are not installed.

Using Terraform provider 2.6.0 that is based on Helm 3.9.0.

@jmeridth
Copy link
Member

@chr-b yeah, the issue seems to be doing this through the helm terraform provider. My local testing has all CRDs installing on fresh cluster. That's not using terraform helm provider. I'll test with that. Thank you for filing issue and possibly noticing link to #1430. Cheers.

@jmeridth
Copy link
Member

@chr-b after doing some research, looks like the terraform helm provider and helm have an ongoing issue re: the crds folder. I've created a PR to move the crds folder into the templates folder and match the technique of the other helm charts we manage re: conditionals to install and keep CRDs. /cc @christophercutajar

Thank you both for your patience and filing these issues. Once this PR gets merged I'd appreciate a test of your terraform usage to confirm this fixes these issues. If it does not, please re-open them.

@jmeridth jmeridth self-assigned this Sep 21, 2022
jmeridth added a commit to jmeridth/argo-helm that referenced this issue Sep 21, 2022
Fixes argoproj#1430 argoproj#1468

Due to multiple instances where new/changed CRDs for argo-workflows do not
get installed/updated I believe it is time to move the crds folder into
the templates folder like our other helm charts.

I'm aware helm 3 is supposed to handle the crds folder but it seems there
are a few known issues currently [here](hashicorp/terraform-provider-helm#944), [here](helm/helm#11321) and [here](helm/helm#11330) that show that may still
need some work.

Signed-off-by: jmeridth <jmeridth@gmail.com>
jmeridth added a commit that referenced this issue Sep 21, 2022
Fixes #1430 #1468

Due to multiple instances where new/changed CRDs for argo-workflows do not
get installed/updated I believe it is time to move the crds folder into
the templates folder like our other helm charts.

I'm aware helm 3 is supposed to handle the crds folder but it seems there
are a few known issues currently [here](hashicorp/terraform-provider-helm#944), [here](helm/helm#11321) and [here](helm/helm#11330) that show that may still
need some work.

Signed-off-by: jmeridth <jmeridth@gmail.com>

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth
Copy link
Member

jmeridth commented Sep 21, 2022

#1472 merged. Closing this. If you get latest chart 0.19.0 and still experience this issue, please reopen this issue. Cheers.

@chr-b
Copy link

chr-b commented Sep 21, 2022

Thanks @jmeridth, the issue is fixed with chart 0.19.0.

@christophercutajar
Copy link

@jmeridth thanks for fixing this! Was caught up in something else and hadn't time to test with Terraform! @chr-b thanks for confirming - I'll spend sometime during the weekend testing this too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-workflows bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants