Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert tc fix to avoid pre- and post-sweepers run for every service package #5932

Conversation

modular-magician
Copy link
Collaborator

The commit a7c143e86340b51eba3b4a0b69eb447a12dfdc47 actually is working and fixed the original issue in the command line to run the script. The reason to revert it is because of another bug, that the sweepers are run for every package.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#8428

…ackage (hashicorp#8428)

* Revert "Fix the folder to run sweepers (hashicorp#8425)"

This reverts commit 18d4037c4ba353ac3a93aa9da43c8df2b0d1de46.

* Revert "pre-sweeper and post-sweeper should only run in the google/google-beta package for now (hashicorp#8423)"

This reverts commit 762c77b0a4e6c28424d08d6cf5951549e109edfd.

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit b2f8a98 into hashicorp:main Jul 22, 2023
@modular-magician modular-magician deleted the downstream-pr-bed80bf83dc93bae4656cc35a9bb047fb0634fe6 branch November 16, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant