Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert tc fix to avoid pre- and post-sweepers run for every service package #8428

Merged
merged 2 commits into from
Jul 22, 2023

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Jul 22, 2023

The commit a7c143e actually is working and fixed the original issue in the command line to run the script. The reason to revert it is because of another bug, that the sweepers are run for every package.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@zli82016 zli82016 requested a review from shuyama1 July 22, 2023 00:15
@shuyama1
Copy link
Member

We need to find a way to run pre-sweeper and post-sweeper only once before and after all tests run with our new teamcity setup

@shuyama1 shuyama1 changed the title Revert tc fix Revert tc fix to avoid pre- and post-sweepers run for every service package Jul 22, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 4 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 2 files changed, 4 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@zli82016 zli82016 merged commit bed80bf into main Jul 22, 2023
@zli82016 zli82016 deleted the revert-tc-fix branch July 22, 2023 00:26
epk pushed a commit to epk/magic-modules that referenced this pull request Jul 24, 2023
…ackage (GoogleCloudPlatform#8428)

* Revert "Fix the folder to run sweepers (GoogleCloudPlatform#8425)"

This reverts commit 18d4037.

* Revert "pre-sweeper and post-sweeper should only run in the google/google-beta package for now (GoogleCloudPlatform#8423)"

This reverts commit 762c77b.
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
…ackage (GoogleCloudPlatform#8428)

* Revert "Fix the folder to run sweepers (GoogleCloudPlatform#8425)"

This reverts commit 18d4037.

* Revert "pre-sweeper and post-sweeper should only run in the google/google-beta package for now (GoogleCloudPlatform#8423)"

This reverts commit 762c77b.
NickElliot pushed a commit to NickElliot/magic-modules that referenced this pull request Jul 31, 2023
…ackage (GoogleCloudPlatform#8428)

* Revert "Fix the folder to run sweepers (GoogleCloudPlatform#8425)"

This reverts commit 18d4037.

* Revert "pre-sweeper and post-sweeper should only run in the google/google-beta package for now (GoogleCloudPlatform#8423)"

This reverts commit 762c77b.
DanielRieske pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 2, 2023
…ackage (GoogleCloudPlatform#8428)

* Revert "Fix the folder to run sweepers (GoogleCloudPlatform#8425)"

This reverts commit 18d4037.

* Revert "pre-sweeper and post-sweeper should only run in the google/google-beta package for now (GoogleCloudPlatform#8423)"

This reverts commit 762c77b.
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Aug 9, 2023
…ackage (GoogleCloudPlatform#8428)

* Revert "Fix the folder to run sweepers (GoogleCloudPlatform#8425)"

This reverts commit 18d4037.

* Revert "pre-sweeper and post-sweeper should only run in the google/google-beta package for now (GoogleCloudPlatform#8423)"

This reverts commit 762c77b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants