-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert tc fix to avoid pre- and post-sweepers run for every service package #8428
Conversation
This reverts commit 18d4037.
We need to find a way to run pre-sweeper and post-sweeper only once before and after all tests run with our new teamcity setup |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 4 insertions(+), 5 deletions(-)) |
…ackage (GoogleCloudPlatform#8428) * Revert "Fix the folder to run sweepers (GoogleCloudPlatform#8425)" This reverts commit 18d4037. * Revert "pre-sweeper and post-sweeper should only run in the google/google-beta package for now (GoogleCloudPlatform#8423)" This reverts commit 762c77b.
…ackage (GoogleCloudPlatform#8428) * Revert "Fix the folder to run sweepers (GoogleCloudPlatform#8425)" This reverts commit 18d4037. * Revert "pre-sweeper and post-sweeper should only run in the google/google-beta package for now (GoogleCloudPlatform#8423)" This reverts commit 762c77b.
…ackage (GoogleCloudPlatform#8428) * Revert "Fix the folder to run sweepers (GoogleCloudPlatform#8425)" This reverts commit 18d4037. * Revert "pre-sweeper and post-sweeper should only run in the google/google-beta package for now (GoogleCloudPlatform#8423)" This reverts commit 762c77b.
…ackage (GoogleCloudPlatform#8428) * Revert "Fix the folder to run sweepers (GoogleCloudPlatform#8425)" This reverts commit 18d4037. * Revert "pre-sweeper and post-sweeper should only run in the google/google-beta package for now (GoogleCloudPlatform#8423)" This reverts commit 762c77b.
…ackage (GoogleCloudPlatform#8428) * Revert "Fix the folder to run sweepers (GoogleCloudPlatform#8425)" This reverts commit 18d4037. * Revert "pre-sweeper and post-sweeper should only run in the google/google-beta package for now (GoogleCloudPlatform#8423)" This reverts commit 762c77b.
The commit a7c143e actually is working and fixed the original issue in the command line to run the script. The reason to revert it is because of another bug, that the sweepers are run for every package.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)