Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_windows_web_app, azurerm_linux_web_app, azurerm_windows_function_app, azurerm_linux_function_app - Terraform will no longer plan when site_config.0.cors are the default values #28703

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Feb 6, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

There was a perpetual diff caused by cors that can only be fixed by setting that field as Optional/Computed

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_windows_web_app, azurerm_linux_web_app, azurerm_windows_function_app, azurerm_linux_function_app - site_config.0.cors is now Optional/Computed to fix a perpetual diff [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #22879

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@mbfrahry mbfrahry force-pushed the b-functionapp-cors-setting branch from 1fa019e to 0a04338 Compare February 7, 2025 19:12
@github-actions github-actions bot added size/S and removed size/XS labels Feb 7, 2025
@mbfrahry mbfrahry changed the title azurerm_windows_web_app, azurerm_linux_web_app, azurerm_windows_function_app, azurerm_linux_function_app - site_config.0.cors is now Optional/Computed to fix a perpetual diff azurerm_windows_web_app, azurerm_linux_web_app, azurerm_windows_function_app, azurerm_linux_function_app - Changes are ignored when site_config.0.cors wants to update to the default values and the state doesn't have it set Feb 7, 2025
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbfrahry - LGTM 👍

@mbfrahry mbfrahry changed the title azurerm_windows_web_app, azurerm_linux_web_app, azurerm_windows_function_app, azurerm_linux_function_app - Changes are ignored when site_config.0.cors wants to update to the default values and the state doesn't have it set azurerm_windows_web_app, azurerm_linux_web_app, azurerm_windows_function_app, azurerm_linux_function_app - Terraform will no longer plan when site_config.0.cors are the default values Feb 10, 2025
@mbfrahry mbfrahry added this to the v4.19.0 milestone Feb 10, 2025
@mbfrahry mbfrahry merged commit c4b300a into main Feb 10, 2025
30 checks passed
@mbfrahry mbfrahry deleted the b-functionapp-cors-setting branch February 10, 2025 19:07
mbfrahry added a commit that referenced this pull request Feb 10, 2025
jackofallops added a commit that referenced this pull request Feb 14, 2025
* CHANGELOG.md for v4.19.0

* Update CHANGELOG.md #28523

* Update CHANGELOG.md #28691

* Updated to include #28717

* Update for #26680

* Update CHANGELOG.md #28633

* Update CHANGELOG.md for #28703

* Update CHANGELOG.md for #28391

* Update CHANGELOG.md #28725

* Update #28733

* Update CHANGELOG.md #28659

* Update for #28741

* Update CHANGELOG.md #28712

* Update CHANGELOG.md #28441

* Update CHANGELOG.md #28441

* Update CHANGELOG.md #28441

* Update CHANGELOG.md for #28602

* Update for #27424

* Update CHANGELOG.md for #28524

* Update CHANGELOG.md #28726

* Update for #28767

* Update for #28195

* prep for release v4.19.0

---------

Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: Wyatt Fry <wyattfry@gmail.com>
Co-authored-by: Matthew Frahry <mbfrahry@gmail.com>
Co-authored-by: jackofallops <ste@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants