Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource - azurerm_virtual_machine_scale_set_standby_pool #28441

Merged
merged 8 commits into from
Feb 11, 2025
Merged

New Resource - azurerm_virtual_machine_scale_set_standby_pool #28441

merged 8 commits into from
Feb 11, 2025
+1,624 −1

Conversation

ms-zhenhua
Copy link
Contributor

@ms-zhenhua ms-zhenhua commented Jan 8, 2025 •
edited
Loading

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Note: To run testcases, you need to follow this document to assign the appropriate permissions to the standby pool resource provider.

Swagger Link: https://github.com/Azure/azure-rest-api-specs/tree/main/specification/standbypool/resource-manager/Microsoft.StandbyPool/stable/2024-03-01

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • New Resource - azurerm_virtual_machine_scale_set_standby_pool

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@ms-zhenhua ms-zhenhua marked this pull request as ready for review January 8, 2025 07:25
@ms-zhenhua ms-zhenhua requested a review from a team as a code owner January 8, 2025 07:25
catriona-m
catriona-m requested changes Feb 5, 2025
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @ms-zhenhua - I left a couple of comments inline but once those are addressed I can take another look. Thanks!

internal/services/compute/virtual_machine_scale_set_standby_pool_resource_test.go Outdated Show resolved Hide resolved
internal/services/compute/virtual_machine_scale_set_standby_pool_resource_test.go Outdated
%s

resource "azurerm_virtual_machine_scale_set_standby_pool" "test" {
name = "acc-%d"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "acc-%d"
name = "acctest-%d"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. Thanks.

internal/services/compute/virtual_machine_scale_set_standby_pool_resource_test.go Outdated
}

resource "azurerm_virtual_machine_scale_set_standby_pool" "test" {
name = "acc-%[2]d"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "acc-%[2]d"
name = "acctest-%[2]d"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. Thanks.

internal/services/compute/virtual_machine_scale_set_standby_pool_resource_test.go Outdated
%s

resource "azurerm_virtual_machine_scale_set_standby_pool" "test" {
name = "acc-%d"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "acc-%d"
name = "acctest-%d"

Copy link
Contributor Author

@ms-zhenhua ms-zhenhua Feb 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. Thanks.

internal/services/compute/virtual_machine_scale_set_standby_pool_resource_test.go Outdated
%s

resource "azurerm_virtual_machine_scale_set_standby_pool" "test" {
name = "acc-%d"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "acc-%d"
name = "acctest-%d"

Copy link
Contributor Author

@ms-zhenhua ms-zhenhua Feb 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. Thanks.

@ms-zhenhua
Copy link
Contributor Author

Hi @catriona-m, thank you for the review. I resolved the first comment. I cannot resolve others due to this reason. Please kindly help take another look.

@ms-zhenhua ms-zhenhua requested a review from catriona-m February 6, 2025 02:28
@catriona-m
Copy link
Member

Hi @catriona-m, thank you for the review. I resolved the first comment. I cannot resolve others due to this reason. Please kindly help take another look.

Thanks for explaining @ms-zhenhua. In this case we could use data.RandomIntOfLength() to ensure the name isn't too big. WDYT?

@ms-zhenhua
Copy link
Contributor Author

Thanks for explaining @ms-zhenhua. In this case we could use data.RandomIntOfLength() to ensure the name isn't too big. WDYT?

Hi @catriona-m, thanks for your solution. I have updated the code. Could you please help take another look?

catriona-m
catriona-m approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-zhenhua LGTM!

@catriona-m catriona-m merged commit 7db4561 into hashicorp:main Feb 11, 2025
35 checks passed
@github-actions github-actions bot added this to the v4.19.0 milestone Feb 11, 2025
catriona-m added a commit that referenced this pull request Feb 11, 2025
@catriona-m
Update CHANGELOG.md #28441
18c286d
catriona-m added a commit that referenced this pull request Feb 11, 2025
@catriona-m
Update CHANGELOG.md #28441
dff1486
catriona-m added a commit that referenced this pull request Feb 11, 2025
@catriona-m
Update CHANGELOG.md #28441
73a9d32
jackofallops added a commit that referenced this pull request Feb 14, 2025
@catriona-m @sreallymatt
@WodansSon @stephybun @wyattfry @mbfrahry @jackofallops
CHANGELOG.md for v4.19.0 (#28714)
0c9e77f 
* CHANGELOG.md for v4.19.0

* Update CHANGELOG.md #28523

* Update CHANGELOG.md #28691

* Updated to include #28717

* Update for #26680

* Update CHANGELOG.md #28633

* Update CHANGELOG.md for #28703

* Update CHANGELOG.md for #28391

* Update CHANGELOG.md #28725

* Update #28733

* Update CHANGELOG.md #28659

* Update for #28741

* Update CHANGELOG.md #28712

* Update CHANGELOG.md #28441

* Update CHANGELOG.md #28441

* Update CHANGELOG.md #28441

* Update CHANGELOG.md for #28602

* Update for #27424

* Update CHANGELOG.md for #28524

* Update CHANGELOG.md #28726

* Update for #28767

* Update for #28195

* prep for release v4.19.0

---------

Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: Wyatt Fry <wyattfry@gmail.com>
Co-authored-by: Matthew Frahry <mbfrahry@gmail.com>
Co-authored-by: jackofallops <ste@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catriona-m catriona-m catriona-m approved these changes

Assignees

@catriona-m catriona-m

Labels
dependencies documentation size/XL
Projects
None yet
Milestone
v4.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ms-zhenhua @catriona-m