Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing grammar updates to Terraform #23

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Add missing grammar updates to Terraform #23

merged 2 commits into from
Mar 17, 2022

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Mar 17, 2022

I missed these two fixes from #8 and #9 while copying patterns from HCL to Terraform.

@dbanck dbanck added the bug Something isn't working label Mar 17, 2022
@dbanck dbanck added this to the 0.2.0 milestone Mar 17, 2022
@dbanck dbanck requested a review from a team March 17, 2022 17:39
@dbanck dbanck self-assigned this Mar 17, 2022
radeksimko
radeksimko reviewed Mar 17, 2022
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need to update tests to test for this fix?

@dbanck
Copy link
Member Author

dbanck commented Mar 17, 2022

Good catch! We only had tests for this for HCL not Terraform. I've added the missing tests.

@dbanck dbanck merged commit a25a902 into main Mar 17, 2022
@dbanck dbanck deleted the b-missed-tf-parts branch March 17, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees

@dbanck dbanck

Labels
bug Something isn't working
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dbanck @radeksimko