Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix highlighting of multi-line bracket expressions #9

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Mar 4, 2022

By including expressions, we enable nested parenthesis to work. Additionally, we include comments since those are not part of the include patterns in expressions.

Before

CleanShot 2022-03-02 at 17 28 23@2x

After

CleanShot 2022-03-02 at 17 27 59@2x

Closes hashicorp/vscode-terraform#941

dbanck added 2 commits March 4, 2022 18:04
By including expressions, we enable nested parenthesis to work.
Additionally, we include comments since those are not part of the
include patterns in expressions.
@dbanck dbanck self-assigned this Mar 4, 2022
@dbanck dbanck added the bug Something isn't working label Mar 4, 2022
@jpogran jpogran added this to the 0.1.0 milestone Mar 7, 2022
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@jpogran jpogran modified the milestones: 0.1.0, 0.2.0 Mar 15, 2022
@dbanck dbanck merged commit 8fd8831 into main Mar 15, 2022
@dbanck dbanck deleted the b-comment-multiline-bracket branch March 15, 2022 18:26
@dbanck dbanck modified the milestones: 0.2.0, 0.1.0 Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support comment highlighting inside multi-line bracketed expressions
3 participants