Remove old (unused) logic related to legacy expressions #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Do we want to keep the legacy tests which have been updated to use the new Constraint?
I think the simple answer here would be: If they cover the same LOC (as per go test -cover) or we at least achieve the same % coverage as without them, then we should feel free to remove them. If not then we should investigate the delta and maybe keep those tests and/or rewrite them.
In the interest of keeping PRs small and opened for short time though I'd leave this for another one.
This was referenced Jan 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #267
TODO
Constraintin Update legacy tests to useConstraint#251