Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decoder/schema: Remove old (unused) logic related to legacy expressions #267

Closed
3 tasks done
radeksimko opened this issue Apr 25, 2023 · 0 comments · Fixed by #354
Closed
3 tasks done

decoder/schema: Remove old (unused) logic related to legacy expressions #267

radeksimko opened this issue Apr 25, 2023 · 0 comments · Fixed by #354
Assignees

Comments

@radeksimko
Copy link
Member

radeksimko commented Apr 25, 2023

Context

As part of some recent PRs we introduced Constraint to schema.AttributeSchema:

// Constraint represents expression constraint e.g. what types of
// expressions are expected for the attribute
Constraint Constraint

This is now used as the primary way to describe attribute's RHS (expression) constraints.

This leaves us with the old/legacy way still in place which is now unused

// Expr represents expression constraints e.g. what types of
// expressions are expected for the attribute
Expr ExprConstraints

and also no longer covered by tests #251

Proposal

  • schema: Remove Expr from AttributeSchema
  • schema: Remove any logic related to Expr
  • decoder: Remove any logic related to Expr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants