Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of NET-7025 - ci: test-integrations failures in compatibility tests. panics occuring in selectionTracker.TrackIDForSelection into release/1.17.x #20230

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #20040 to be assessed for backporting due to the inclusion of the label backport/1.17.

The below text is copied from the body of the original PR.


Description

We are seeing the following panics in CI:

Error: sul-server-0-nckhszq0l ~~ 2023-12-21T21:08:23.587Z [ERROR] agent.controller-runtime: controller panic: controller=consul.io/sidecar-proxy-controller managed_type=mesh.v2beta1.ProxyStateTemplate panic="runtime error: invalid memory address or nil pointer dereference"
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/go-hclog.Stacktrace
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/go/pkg/mod/github.com/hashicorp/go-hclog@v1.5.0/stacktrace.go:51
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/controller.(*controllerRunner).handlePanic.func1
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/controller/runner.go:254
  dc1-consul-server-0-nckhszq0l ~~ runtime.gopanic
  dc1-consul-server-0-nckhszq0l ~~ 	/opt/hostedtoolcache/go/1.20.12/x64/src/runtime/panic.go:884
  dc1-consul-server-0-nckhszq0l ~~ runtime.panicmem
  dc1-consul-server-0-nckhszq0l ~~ 	/opt/hostedtoolcache/go/1.20.12/x64/src/runtime/panic.go:260
  dc1-consul-server-0-nckhszq0l ~~ runtime.sigpanic
  dc1-consul-server-0-nckhszq0l ~~ 	/opt/hostedtoolcache/go/1.20.12/x64/src/runtime/signal_unix.go:841
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/resource/mappers/selectiontracker.(*WorkloadSelectionTracker).TrackIDForSelector
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/resource/mappers/selectiontracker/selection_tracker.go:80
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/mesh/internal/controllers/sidecarproxy/cache.(*Cache).TrackService
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/mesh/internal/controllers/sidecarproxy/cache/cache.go:134
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/mesh/internal/controllers/sidecarproxy/cache.(*Cache).MapService
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/mesh/internal/controllers/sidecarproxy/cache/cache.go:143
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/controller.(*controllerRunner).run.func3.1
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/controller/runner.go:78
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/controller.(*controllerRunner).doMap.func1
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/controller/runner.go:206
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/controller.(*controllerRunner).handlePanic
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/controller/runner.go:264
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/controller.(*controllerRunner).doMap
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/controller/runner.go:204
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/controller.(*controllerRunner).runMapper
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/controller/runner.go:165
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/controller.(*controllerRunner).run.func3
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/controller/runner.go:77
  dc1-consul-server-0-nckhszq0l ~~ golang.org/x/sync/errgroup.(*Group).Go.func1
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/go/pkg/mod/golang.org/x/sync@v0.3.0/errgroup/errgroup.go:75

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@hashi-derek hashi-derek enabled auto-merge (squash) January 16, 2024 22:37
@hashi-derek hashi-derek assigned hashi-derek and unassigned jmurret Jan 16, 2024
@hashi-derek hashi-derek merged commit 39d60cd into release/1.17.x Jan 16, 2024
96 checks passed
@hashi-derek hashi-derek deleted the backport/jm/NET-7025/jolly-known-mackerel branch January 16, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants