Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-7025 - ci: test-integrations failures in compatibility tests. panics occuring in selectionTracker.TrackIDForSelection #20040

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

jmurret
Copy link
Member

@jmurret jmurret commented Dec 21, 2023

Description

We are seeing the following panics in CI:

Error: sul-server-0-nckhszq0l ~~ 2023-12-21T21:08:23.587Z [ERROR] agent.controller-runtime: controller panic: controller=consul.io/sidecar-proxy-controller managed_type=mesh.v2beta1.ProxyStateTemplate panic="runtime error: invalid memory address or nil pointer dereference"
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/go-hclog.Stacktrace
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/go/pkg/mod/github.com/hashicorp/go-hclog@v1.5.0/stacktrace.go:51
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/controller.(*controllerRunner).handlePanic.func1
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/controller/runner.go:254
  dc1-consul-server-0-nckhszq0l ~~ runtime.gopanic
  dc1-consul-server-0-nckhszq0l ~~ 	/opt/hostedtoolcache/go/1.20.12/x64/src/runtime/panic.go:884
  dc1-consul-server-0-nckhszq0l ~~ runtime.panicmem
  dc1-consul-server-0-nckhszq0l ~~ 	/opt/hostedtoolcache/go/1.20.12/x64/src/runtime/panic.go:260
  dc1-consul-server-0-nckhszq0l ~~ runtime.sigpanic
  dc1-consul-server-0-nckhszq0l ~~ 	/opt/hostedtoolcache/go/1.20.12/x64/src/runtime/signal_unix.go:841
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/resource/mappers/selectiontracker.(*WorkloadSelectionTracker).TrackIDForSelector
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/resource/mappers/selectiontracker/selection_tracker.go:80
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/mesh/internal/controllers/sidecarproxy/cache.(*Cache).TrackService
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/mesh/internal/controllers/sidecarproxy/cache/cache.go:134
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/mesh/internal/controllers/sidecarproxy/cache.(*Cache).MapService
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/mesh/internal/controllers/sidecarproxy/cache/cache.go:143
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/controller.(*controllerRunner).run.func3.1
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/controller/runner.go:78
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/controller.(*controllerRunner).doMap.func1
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/controller/runner.go:206
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/controller.(*controllerRunner).handlePanic
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/controller/runner.go:264
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/controller.(*controllerRunner).doMap
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/controller/runner.go:204
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/controller.(*controllerRunner).runMapper
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/controller/runner.go:165
  dc1-consul-server-0-nckhszq0l ~~ github.com/hashicorp/consul/internal/controller.(*controllerRunner).run.func3
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/work/consul/consul/internal/controller/runner.go:77
  dc1-consul-server-0-nckhszq0l ~~ golang.org/x/sync/errgroup.(*Group).Go.func1
  dc1-consul-server-0-nckhszq0l ~~ 	/home/runner/go/pkg/mod/golang.org/x/sync@v0.3.0/errgroup/errgroup.go:75

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@jmurret jmurret added backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. pr/no-changelog PR does not need a corresponding .changelog entry labels Dec 21, 2023
@jmurret jmurret marked this pull request as ready for review December 21, 2023 22:59
@jmurret jmurret requested a review from a team as a code owner December 21, 2023 22:59
@jmurret jmurret requested a review from rboyer December 21, 2023 23:29
@jmurret jmurret force-pushed the jm/NET-7025 branch 2 times, most recently from 166d377 to 35db5af Compare December 21, 2023 23:35
@jmurret jmurret changed the title ci: test-integrations failures in compatibility tests. panics occuring in selectionTracker.TrackIDForSelection NET-7025 - ci: test-integrations failures in compatibility tests. panics occuring in selectionTracker.TrackIDForSelection Dec 21, 2023
@hc-github-team-consul-core
Copy link
Collaborator

@jmurret jmurret added backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. and removed backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. labels Dec 22, 2023
@jmurret jmurret added pr/no-backport and removed backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. labels Dec 22, 2023
@hashi-derek hashi-derek added the backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants