Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add validation for grpc certificate hash #16776

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

Neeharika-Sompalli
Copy link
Member

Fixes #16751

Adds validation that grpcCertificate hash is not empty

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 50.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (246f42d) 97509 63619 65.24%
Head commit (c7f2322) 97511 (+2) 63616 (-3) 65.24% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16776) 2 1 50.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.53%. Comparing base (246f42d) to head (c7f2322).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...e/addressbook/impl/handlers/NodeUpdateHandler.java 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16776      +/-   ##
=============================================
- Coverage      63.54%   63.53%   -0.01%     
+ Complexity     20372    20370       -2     
=============================================
  Files           2537     2537              
  Lines          94744    94746       +2     
  Branches        9901     9902       +1     
=============================================
- Hits           60201    60198       -3     
- Misses         30936    30941       +5     
  Partials        3607     3607              
Files with missing lines Coverage Δ
...e/addressbook/impl/handlers/NodeUpdateHandler.java 93.24% <50.00%> (+0.18%) ⬆️

... and 10 files with indirect coverage changes

Impacted file tree graph

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @Neeharika-Sompalli !

@Neeharika-Sompalli Neeharika-Sompalli merged commit 935fdb1 into develop Nov 25, 2024
61 of 77 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the 16751-fix-grpcCertHash branch November 25, 2024 20:27
Neeharika-Sompalli added a commit that referenced this pull request Nov 25, 2024
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Neeharika-Sompalli added a commit that referenced this pull request Nov 26, 2024
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate grpcCertHash is not empty during NodeUpdate
2 participants