-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add validation for grpc certificate hash #16776
Conversation
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #16776 +/- ##
=============================================
- Coverage 63.54% 63.53% -0.01%
+ Complexity 20372 20370 -2
=============================================
Files 2537 2537
Lines 94744 94746 +2
Branches 9901 9902 +1
=============================================
- Hits 60201 60198 -3
- Misses 30936 30941 +5
Partials 3607 3607
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tyvm @Neeharika-Sompalli !
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Fixes #16751
Adds validation that grpcCertificate hash is not empty