add validations for grpc certificate hash

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
hashgraph · Nov 25, 2024 · c7f2322 · c7f2322
1 parent 246f42d
commit c7f2322
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/hapi/hedera-protobufs/services/response_code.proto b/hapi/hedera-protobufs/services/response_code.proto
@@ -1614,4 +1614,9 @@ enum ResponseCodeEnum {
      * expire; its creation must be retried with a different expiry.
      */
     SCHEDULE_EXPIRY_IS_BUSY = 372;
+
+    /**
+     * The provided gRPC certificate hash is invalid.
+     */
+    INVALID_GRPC_CERTIFICATE_HASH = 373;
 }
diff --git a/...rc/main/java/com/hedera/node/app/service/addressbook/impl/handlers/NodeUpdateHandler.java b/...rc/main/java/com/hedera/node/app/service/addressbook/impl/handlers/NodeUpdateHandler.java
@@ -18,6 +18,7 @@
 
 import static com.hedera.hapi.node.base.ResponseCodeEnum.INVALID_ADMIN_KEY;
 import static com.hedera.hapi.node.base.ResponseCodeEnum.INVALID_GOSSIP_CA_CERTIFICATE;
+import static com.hedera.hapi.node.base.ResponseCodeEnum.INVALID_GRPC_CERTIFICATE_HASH;
 import static com.hedera.hapi.node.base.ResponseCodeEnum.INVALID_NODE_ACCOUNT_ID;
 import static com.hedera.hapi.node.base.ResponseCodeEnum.INVALID_NODE_ID;
 import static com.hedera.hapi.node.base.ResponseCodeEnum.UPDATE_NODE_ACCOUNT_NOT_ALLOWED;
@@ -75,6 +76,9 @@ public void pureChecks(@NonNull final TransactionBody txn) throws PreCheckExcept
             final var adminKey = op.adminKey();
             addressBookValidator.validateAdminKey(adminKey);
         }
+        if (op.hasGrpcCertificateHash()) {
+            validateFalsePreCheck(op.grpcCertificateHash().equals(Bytes.EMPTY), INVALID_GRPC_CERTIFICATE_HASH);
+        }
     }
 
     @Override

diff --git a/...ava/com/hedera/node/app/service/addressbook/impl/test/handlers/NodeUpdateHandlerTest.java b/...ava/com/hedera/node/app/service/addressbook/impl/test/handlers/NodeUpdateHandlerTest.java
@@ -18,6 +18,7 @@
 
 import static com.hedera.hapi.node.base.ResponseCodeEnum.INVALID_ADMIN_KEY;
 import static com.hedera.hapi.node.base.ResponseCodeEnum.INVALID_GOSSIP_CA_CERTIFICATE;
+import static com.hedera.hapi.node.base.ResponseCodeEnum.INVALID_GRPC_CERTIFICATE_HASH;
 import static com.hedera.hapi.node.base.ResponseCodeEnum.INVALID_NODE_ACCOUNT_ID;
 import static com.hedera.hapi.node.base.ResponseCodeEnum.INVALID_NODE_ID;
 import static com.hedera.hapi.node.base.ResponseCodeEnum.UPDATE_NODE_ACCOUNT_NOT_ALLOWED;
@@ -122,6 +123,18 @@ void gossipCaCertificateCannotEmpty() {
         assertThat(msg.responseCode()).isEqualTo(INVALID_GOSSIP_CA_CERTIFICATE);
     }
 
+    @Test
+    @DisplayName("pureChecks fail when grpcCertHash is empty")
+    void grpcCertHashCannotEmpty() {
+        txn = new NodeUpdateBuilder()
+                .withNodeId(1)
+                .withAccountId(accountId)
+                .withGrpcCertificateHash(Bytes.EMPTY)
+                .build();
+        final var msg = assertThrows(PreCheckException.class, () -> subject.pureChecks(txn));
+        assertThat(msg.responseCode()).isEqualTo(INVALID_GRPC_CERTIFICATE_HASH);
+    }
+
     @Test
     @DisplayName("invalid adminKey fail")
     void adminKeyInvalid() {