-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Cherry pick #10348 #10368
chore: Cherry pick #10348 #10368
Conversation
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.45 #10368 +/- ##
===============================================
Coverage 63.11% 63.12%
- Complexity 30695 30699 +4
===============================================
Files 3332 3332
Lines 134003 134008 +5
Branches 13886 13886
===============================================
+ Hits 84577 84590 +13
+ Misses 46082 46076 -6
+ Partials 3344 3342 -2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description:
Cherry pick #10348 into release/0.45
Related issue(s):
Fixes #10346