Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cherry pick #10348 #10368

Merged
merged 3 commits into from
Dec 7, 2023
Merged

chore: Cherry pick #10348 #10368

merged 3 commits into from
Dec 7, 2023

Conversation

lukelee-sl
Copy link
Member

Description:
Cherry pick #10348 into release/0.45

Related issue(s):

Fixes #10346

Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
@lukelee-sl lukelee-sl self-assigned this Dec 7, 2023
@lukelee-sl lukelee-sl requested a review from a team December 7, 2023 20:11
@lukelee-sl lukelee-sl requested a review from a team as a code owner December 7, 2023 20:11
Copy link

github-actions bot commented Dec 7, 2023

Node: HAPI Test (Crypto) Results

211 tests   201 ✔️  17m 19s ⏱️
  22 suites    10 💤
  22 files        0

Results for commit 1aa76b5.

♻️ This comment has been updated with latest results.

iwsimon
iwsimon previously approved these changes Dec 7, 2023
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Dec 7, 2023

Node: HAPI Test (Token) Results

190 tests   188 ✔️  20m 11s ⏱️
  13 suites      2 💤
  13 files        0

Results for commit 1aa76b5.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 7, 2023

Node: Unit Test Results

    2 288 files  ±0      2 288 suites  ±0   46m 59s ⏱️ + 1m 22s
118 398 tests +1  118 364 ✔️ +1  34 💤 ±0  0 ±0 
126 770 runs  +1  126 736 ✔️ +1  34 💤 ±0  0 ±0 

Results for commit 1aa76b5. ± Comparison against base commit 618c723.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a8bd3d) 63.11% compared to head (1aa76b5) 63.12%.
Report is 2 commits behind head on release/0.45.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/0.45   #10368   +/-   ##
===============================================
  Coverage           63.11%   63.12%           
- Complexity          30695    30699    +4     
===============================================
  Files                3332     3332           
  Lines              134003   134008    +5     
  Branches            13886    13886           
===============================================
+ Hits                84577    84590   +13     
+ Misses              46082    46076    -6     
+ Partials             3344     3342    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 7, 2023

Node: E2E Test Results

    1 files      1 suites   23m 17s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit 1aa76b5.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 7, 2023

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  25m 28s ⏱️
  2 suites  12 💤
  2 files      0

Results for commit 1aa76b5.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 7, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 26s ⏱️ - 1m 38s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 1aa76b5. ± Comparison against base commit 618c723.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 7, 2023

Node: HAPI Test (Smart Contract) Results

405 tests   325 ✔️  46m 31s ⏱️
  56 suites    80 💤
  56 files        0

Results for commit 1aa76b5.

♻️ This comment has been updated with latest results.

Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Copy link

github-actions bot commented Dec 7, 2023

Node: HAPI Test (Misc) Results

419 tests  ±0   313 ✔️ ±0   23m 46s ⏱️ -58s
  73 suites ±0   106 💤 ±0 
  73 files   ±0       0 ±0 

Results for commit 1aa76b5. ± Comparison against base commit 618c723.

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iwsimon iwsimon merged commit 2ccffcf into release/0.45 Dec 7, 2023
23 of 24 checks passed
@iwsimon iwsimon deleted the 10348-cherry-pic branch December 7, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants