feat: Set recipient to null as appropriate during contract tracing #10348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10348 +/- ##
==========================================
Coverage ? 63.52%
Complexity ? 31012
==========================================
Files ? 3342
Lines ? 134702
Branches ? 14009
==========================================
Hits ? 85573
Misses ? 45770
Partials ? 3359 ☔ View full report in Codecov by Sentry. |
...ain/java/com/hedera/node/app/service/mono/contracts/execution/traceability/HederaTracer.java
Show resolved
Hide resolved
…into 10346-set-recipient-to-null
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
lukelee-sl
commented
Dec 7, 2023
...ain/java/com/hedera/node/app/service/mono/contracts/execution/traceability/HederaTracer.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If the recipient address cannot be converted into an Entity Id then set its value to null. We search for the recipient address in both the ledger and in the alias map prior to setting the value to null.
Related issue(s):
Fixes #10346