Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure the pull request check workflow properly handles forks #10268

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

nathanklick
Copy link
Member

Description

This pull request changes the following:

  • Ensures the JRS job of the PR Checks workflow does not execute when the PR is created from a forked repository or by dependabot.

Required Cherry Picks

  • release/0.45

Related Issues

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick nathanklick self-assigned this Dec 5, 2023
@nathanklick nathanklick requested review from a team as code owners December 5, 2023 01:45
Copy link

github-actions bot commented Dec 5, 2023

Node: Unit Test Results

    2 290 files  ±0      2 290 suites  ±0   37m 35s ⏱️ - 10m 6s
118 410 tests ±0  118 375 ✔️ ±0  34 💤 ±0  1 ±0 
126 832 runs  ±0  126 797 ✔️ ±0  34 💤 ±0  1 ±0 

For more details on these failures, see this check.

Results for commit a8bab1c. ± Comparison against base commit 1a2a719.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 276 lines in your changes are missing coverage. Please review.

Comparison is base (b9108aa) 63.63% compared to head (a8bab1c) 63.51%.
Report is 2 commits behind head on develop.

Files Patch % Lines
...ce/mono/state/migration/ContractStateMigrator.java 0.00% 171 Missing ⚠️
.../cli/signedstate/DumpContractStoresSubcommand.java 0.00% 67 Missing ⚠️
.../internal/ContractMigrationValidationCounters.java 0.00% 26 Missing ⚠️
...era/services/cli/signedstate/DumpStateCommand.java 0.00% 8 Missing ⚠️
...ra/services/cli/signedstate/SignedStateHolder.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10268      +/-   ##
=============================================
- Coverage      63.63%   63.51%   -0.13%     
- Complexity     30951    30953       +2     
=============================================
  Files           3335     3337       +2     
  Lines         134100   134351     +251     
  Branches       13925    13965      +40     
=============================================
- Hits           85339    85334       -5     
- Misses         45405    45661     +256     
  Partials        3356     3356              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 5, 2023

Node: HAPI Test (Token) Results

190 tests   188 ✔️  17m 47s ⏱️
  13 suites      2 💤
  13 files        0

Results for commit a8bab1c.

Copy link

github-actions bot commented Dec 5, 2023

Node: HAPI Test (Crypto) Results

211 tests   201 ✔️  17m 45s ⏱️
  22 suites    10 💤
  22 files        0

Results for commit a8bab1c.

Copy link

github-actions bot commented Dec 5, 2023

Node: HAPI Test (Misc) Results

419 tests  ±0   313 ✔️ ±0   20m 32s ⏱️ - 3m 28s
  73 suites ±0   106 💤 ±0 
  73 files   ±0       0 ±0 

Results for commit a8bab1c. ± Comparison against base commit 1a2a719.

Copy link

github-actions bot commented Dec 5, 2023

Node: E2E Test Results

    1 files      1 suites   21m 9s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit a8bab1c.

Copy link

github-actions bot commented Dec 5, 2023

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  24m 36s ⏱️
  2 suites  12 💤
  2 files      0

Results for commit a8bab1c.

Copy link

github-actions bot commented Dec 5, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 24s ⏱️ ±0s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit a8bab1c. ± Comparison against base commit 1a2a719.

Copy link

github-actions bot commented Dec 5, 2023

Node: HAPI Test (Smart Contract) Results

405 tests   325 ✔️  37m 12s ⏱️
  56 suites    80 💤
  56 files        0

Results for commit a8bab1c.

@nathanklick nathanklick merged commit 521d5eb into develop Dec 5, 2023
27 of 31 checks passed
@nathanklick nathanklick deleted the 10229-JRS-Fork-Handling branch December 5, 2023 03:28
nathanklick added a commit that referenced this pull request Dec 5, 2023
…10268)

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure the JRS job in the PR Checks workflow is ignored when executing from a forked pull request
2 participants