Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update e2e and itests to use Java 21 during runtime #10376

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

nathanklick
Copy link
Member

@nathanklick nathanklick commented Dec 8, 2023

Description

This pull request changes the following:

  • Updates the E2E/ITest docker definition to use Java 21 during runtime.
    • Uses ZGC and ZGenerational
    • Adds malloc memory usage fix
    • Optimizes docker build
    • Improves docker image build time (down to ~1 minute depending on internet connection speeds)

Related Issues

@nathanklick nathanklick requested a review from a team December 8, 2023 05:18
@nathanklick nathanklick requested review from a team as code owners December 8, 2023 05:18
Copy link

github-actions bot commented Dec 8, 2023

Node: HAPI Test (Crypto) Results

211 tests   201 ✔️  21m 18s ⏱️
  22 suites    10 💤
  22 files        0

Results for commit 4856851.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 8, 2023

Node: HAPI Test (Token) Results

189 tests   189 ✔️  19m 15s ⏱️
  13 suites      0 💤
  13 files        0

Results for commit 4856851.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 8, 2023

Node: Unit Test Results

    2 294 files  ±0      2 294 suites  ±0   49m 0s ⏱️ + 3m 45s
118 435 tests ±0  118 401 ✔️ ±0  34 💤 ±0  0 ±0 
126 857 runs  ±0  126 823 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit 4856851. ± Comparison against base commit 575da81.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@575da81). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10376   +/-   ##
==========================================
  Coverage           ?   63.51%           
  Complexity         ?    31011           
==========================================
  Files              ?     3342           
  Lines              ?   134710           
  Branches           ?    14006           
==========================================
  Hits               ?    85567           
  Misses             ?    45781           
  Partials           ?     3362           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 8, 2023

Node: E2E Test Results

    1 files      1 suites   21m 26s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit 4856851.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 8, 2023

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  24m 46s ⏱️
  2 suites  12 💤
  2 files      0

Results for commit 4856851.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 8, 2023

Node: HAPI Test (Misc) Results

419 tests  ±0   316 ✔️ ±0   28m 31s ⏱️ +33s
  73 suites ±0   103 💤 ±0 
  73 files   ±0       0 ±0 

Results for commit 4856851. ± Comparison against base commit 575da81.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 8, 2023

Node: HAPI Test (Smart Contract) Results

397 tests   352 ✔️  52m 21s ⏱️
  55 suites    45 💤
  55 files        0

Results for commit 4856851.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 8, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 28s ⏱️ +26s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 4856851. ± Comparison against base commit 575da81.

♻️ This comment has been updated with latest results.

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick nathanklick force-pushed the 10268-E2E-Java21-Support branch from 0eb0426 to 4856851 Compare December 8, 2023 17:51
@nathanklick nathanklick merged commit 49ffd96 into develop Dec 8, 2023
24 checks passed
@nathanklick nathanklick deleted the 10268-E2E-Java21-Support branch December 8, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the E2E and ITest docker base image to run using Java 21
7 participants