add button #52
Merged
add button #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ryanchansf
requested changes
Feb 23, 2024
frontend/src/app/page.tsx
Outdated
| return ( | ||
| <main> | ||
| <h1>Home</h1> | ||
| <ProposalTable /> |
There was a problem hiding this comment.
The button looks good! But we don't want to get rid of the proposal table just yet. When we eventually link the table to the backend, we'll have some conditional rendering to have it appear only after having clicked the button to run the webscraper. But for now, we can just leave the table as is.
ryanchansf
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer: {Hayley Chang}
Closes #{45}
Pull Request Summary
{Add button for webscraper}
Modifications
{add button and description to run webscraper}
Testing Considerations
{list out what you have tested and what the reviewer should verify}
Pull Request Checklist
Screenshots/Screencast
{put screenshots of your change, or even better a screencast displaying the functionality}