-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gwsumm to handle updated gwbootstrap #399
Conversation
@iaraota I expect this PR will fail until the gwdetchar PR is also merged and released |
a428e47
to
cfb4295
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #399 +/- ##
=======================================
Coverage 49.64% 49.64%
=======================================
Files 60 60
Lines 8823 8823
=======================================
Hits 4380 4380
Misses 4443 4443
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cfb4295
to
c45d2e9
Compare
@iaraota I don't quite understand why the readthedocs CI is failing. There seems to be something wrong when readthedocs tries to install packages in its build process |
8ad6945
to
cf182de
Compare
cf182de
to
dc746d2
Compare
@iaraota All checks now pass! Please let me know about your review. Thanks! |
The packages for gwdetchar are being updated, see gwdetchar/gwbootstrap#49. There are some slight modifications needed for the html dropdown menus and JS/CSS package pins needed for gwdetchar to be compatible.
I also take the opportunity to update the github action versions