Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gwsumm to handle updated gwbootstrap #399

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

eagoetz
Copy link
Collaborator

@eagoetz eagoetz commented Mar 19, 2024

The packages for gwdetchar are being updated, see gwdetchar/gwbootstrap#49. There are some slight modifications needed for the html dropdown menus and JS/CSS package pins needed for gwdetchar to be compatible.

I also take the opportunity to update the github action versions

@eagoetz eagoetz self-assigned this Mar 19, 2024
@eagoetz eagoetz added this to the 2.2.4 milestone Mar 19, 2024
@eagoetz eagoetz added the html label Mar 19, 2024
@eagoetz eagoetz requested a review from iaraota March 19, 2024 23:30
@eagoetz
Copy link
Collaborator Author

eagoetz commented Mar 20, 2024

@iaraota I expect this PR will fail until the gwdetchar PR is also merged and released

@eagoetz eagoetz force-pushed the gwbootstrap-update branch 2 times, most recently from a428e47 to cfb4295 Compare March 22, 2024 22:46
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.64%. Comparing base (720bd0c) to head (dc746d2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #399   +/-   ##
=======================================
  Coverage   49.64%   49.64%           
=======================================
  Files          60       60           
  Lines        8823     8823           
=======================================
  Hits         4380     4380           
  Misses       4443     4443           
Flag Coverage Δ
Linux ?
macOS 49.64% <100.00%> (?)
python3.10 49.64% <100.00%> (ø)
python3.11 49.64% <100.00%> (ø)
python3.9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eagoetz eagoetz force-pushed the gwbootstrap-update branch from cfb4295 to c45d2e9 Compare March 22, 2024 22:53
@eagoetz
Copy link
Collaborator Author

eagoetz commented Mar 22, 2024

@iaraota I don't quite understand why the readthedocs CI is failing. There seems to be something wrong when readthedocs tries to install packages in its build process

@duncanmmacleod
Copy link
Member

@iaraota I don't quite understand why the readthedocs CI is failing. There seems to be something wrong when readthedocs tries to install packages in its build process

@eagoetz, @iaraota, please see #400 for a workaround.

@eagoetz eagoetz force-pushed the gwbootstrap-update branch from 8ad6945 to cf182de Compare March 25, 2024 16:02
@eagoetz eagoetz force-pushed the gwbootstrap-update branch from cf182de to dc746d2 Compare March 25, 2024 16:15
@eagoetz
Copy link
Collaborator Author

eagoetz commented Mar 25, 2024

@iaraota All checks now pass! Please let me know about your review. Thanks!

@eagoetz eagoetz merged commit dcb72a1 into gwpy:master Mar 25, 2024
10 checks passed
@eagoetz eagoetz deleted the gwbootstrap-update branch March 25, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants