Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package info #49

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Conversation

eagoetz
Copy link
Member

@eagoetz eagoetz commented Mar 18, 2024

Updating version, contributors, dependency version. This requires some small modifications to how the fancybox activation works upon user click.

See https://ldas-jobs.ligo-wa.caltech.edu/~detchar/summary/index-eg.html for a working example

@eagoetz eagoetz added this to the 1.3.3 milestone Mar 18, 2024
@eagoetz eagoetz self-assigned this Mar 18, 2024
Copy link
Collaborator

@areeda areeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTN

@iaraota
Copy link

iaraota commented Mar 20, 2024

Hi @eagoetz, what should I test in the example? (calendar clicks raises an error)

@eagoetz
Copy link
Member Author

eagoetz commented Mar 20, 2024

Hi @eagoetz, what should I test in the example? (calendar clicks raises an error)

@iaraota Yeah, the calendar clicks from the landing page are the issue solved in the other PR I asked you to review. Here I just wanted you to check that the other dropdowns work as expected, which I think they do

@eagoetz eagoetz force-pushed the update-package-info branch from de4aad6 to 11df16a Compare March 20, 2024 20:57
@eagoetz eagoetz merged commit ffee779 into gwdetchar:master Mar 21, 2024
@eagoetz eagoetz deleted the update-package-info branch March 21, 2024 00:22
eagoetz added a commit to gwdetchar/gwdetchar that referenced this pull request Mar 21, 2024
See gwdetchar/gwbootstrap#49

Co-authored-by: Evan Goetz <evan.goetz@ligo.org>
eagoetz pushed a commit to eagoetz/gwsumm that referenced this pull request Mar 22, 2024
eagoetz pushed a commit to eagoetz/gwsumm that referenced this pull request Mar 25, 2024
eagoetz added a commit to gwpy/gwsumm that referenced this pull request Mar 25, 2024
* Update gwsumm to handle updated gwbootstrap

See gwdetchar/gwbootstrap#49

* Update action versions

---------

Co-authored-by: Evan Goetz <evan.goetz@ligo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file downstream:gwdetchar downstream:gwsumm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants