Allow RA/dec unit suffix in make_sky_grid #4988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
pannarale
approved these changes
Dec 13, 2024
MarcoCusinato
approved these changes
Dec 13, 2024
|
Minimal testing done. |
6815393 to
47bb4ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the
degandradsuffixes to be used inpycbc_make_sky_grid.Standard information about the request
This is a new feature.
This change affects mostly PyGRB at this time.
This change will not break functionality.
Motivation
I forgot to do this in #4965. Fixes #4986.
Contents
Trivial change. I took the opportunity to also reformat the code in a separate commit.
Links to any issues or associated PRs
#4965 and #4986.
Testing performed
None.
Additional notes
N/A