Generate and use search sky-grids in pygrb worflows #4985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pannarale
commented
Dec 12, 2024
This reverts commit 4a568c4.
|
@pannarale please rebase on master to pick up both the sky grid change and the fix for the failing CI. |
titodalcanton
requested changes
Dec 17, 2024
Co-authored-by: Tito Dal Canton <tito@dalcanton.it>
titodalcanton
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard information about the request
This is a: new feature
This change affects: PyGRB
This change changes: scientific output
Motivation
pycbc_multi_inspiralcan loop over several search sky points andpycbc_make_sky_gridcan generate such grid. This PR sets up a job for the latter and passes the grid around to the former, within a PyGRB workflow.Contents
The appropriate workflow .py files and the workflow generator are upgraded accordingly.
Dependencies
#4988
Testing performed
Coming up...
Additional notes