-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idq live #4850
Merged
Merged
Idq live #4850
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
98377f3
Have pycbc live mark flagged triggers instead of removing
maxtrevor c2e1af7
Make stat usable in low-latency
maxtrevor 9b2b67a
Add command line argument for whether to use idq for reweighting
maxtrevor a3e9069
Add logging for iDQ flagged triggers
maxtrevor ff7b2d1
Fix bug when using ifo with no dq
maxtrevor 533df3b
Improve logic for getting ifo frm trigs
maxtrevor d14f729
Update for compatibility with Gareth's stat reloading code
maxtrevor 6c9b728
Modify how trig ifo is gotten and add debug statements
maxtrevor a999f4b
Use logging not print for debugging
maxtrevor f4fdac8
logger not logging
maxtrevor 34bbaff
Fix where tnum is set
maxtrevor 034ad0e
Get rid of excess logging
maxtrevor 7f13fd9
Address Gareth's comments
maxtrevor 5a8ecc7
Codeclimate
maxtrevor 3e8ae49
Apply suggestions from code review
maxtrevor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
logger not logging
- Loading branch information
commit f4fdac80303c601bfc1c7dd989a2d423a93e1cec
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2411,22 +2411,22 @@ def find_dq_noise_rate(self, trigs): | |
|
||
try: | ||
ifo = trigs.ifo | ||
logging.info('DEBUG in find_dq_noise_rate: trigs.ifo worked successfully') | ||
logger.info('DEBUG in find_dq_noise_rate: trigs.ifo worked successfully') | ||
except AttributeError: | ||
ifo = trigs.get('ifo', None) | ||
if ifo is None: | ||
logging.info('DEBUG in find_dq_noise_rate: ifo is none after trigs.get') | ||
logging.info(f'DEBUG in find_dq_noise_rate: stat ifos: {self.ifos}') | ||
logger.info('DEBUG in find_dq_noise_rate: ifo is none after trigs.get') | ||
logger.info(f'DEBUG in find_dq_noise_rate: stat ifos: {self.ifos}') | ||
ifo = self.ifos[0] | ||
else: | ||
logging.info('DEBUG in find_dq_noise_rate: trigs.get worked') | ||
logger.info('DEBUG in find_dq_noise_rate: trigs.get worked') | ||
assert ifo in self.ifos | ||
|
||
dq_state = trigs['dq_state'] | ||
dq_val = numpy.ones(len(dq_state)) | ||
|
||
tnum = self.curr_tnum | ||
GarethCabournDavies marked this conversation as resolved.
Show resolved
Hide resolved
|
||
logging.info(f'DEBUG in find_dq_noise_rate: tnum: {tnum}') | ||
logger.info(f'DEBUG in find_dq_noise_rate: tnum: {tnum}') | ||
if ifo in self.dq_rates_by_state: | ||
for (i, st) in enumerate(dq_state): | ||
if isinstance(tnum, numpy.ndarray): | ||
|
@@ -2479,15 +2479,15 @@ def single(self, trigs): | |
# make sure every trig has a dq state | ||
try: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think an |
||
ifo = trigs.ifo | ||
logging.info('DEBUG in single: trigs.ifo worked successfully') | ||
logger.info('DEBUG in single: trigs.ifo worked successfully') | ||
except AttributeError: | ||
ifo = trigs.get('ifo', None) | ||
if ifo is None: | ||
logging.info('DEBUG in single: ifo is none after trigs.get') | ||
logging.info(f'DEBUG in single: stat ifos: {self.ifos}') | ||
logger.info('DEBUG in single: ifo is none after trigs.get') | ||
logger.info(f'DEBUG in single: stat ifos: {self.ifos}') | ||
ifo = self.ifos[0] | ||
else: | ||
logging.info('DEBUG in single: trigs.get worked') | ||
logger.info('DEBUG in single: trigs.get worked') | ||
assert ifo in self.ifos | ||
|
||
singles = ExpFitFgBgNormStatistic.single(self, trigs) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This try/except is used a couple of times now. It would be good to be in a function. Codeclimate will probably complain