Idq live #4850
Merged
Idq live #4850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noting that this is the completed version of a previous draft MR: #4818 |
GarethCabournDavies
requested changes
Aug 14, 2024
| dq_rate = numpy.maximum(dq_rate, 1) | ||
|
|
||
| logr_n = ExpFitFgBgNormStatistic.lognoiserate( | ||
| self, trigs) | ||
| logr_n += numpy.log(dq_rate) | ||
| return logr_n | ||
|
|
||
| def single(self, trigs): | ||
| # make sure every trig has a dq state | ||
| try: |
There was a problem hiding this comment.
I think an if hasattr(self, 'ifo') would be nicer here than the try/except. However I know that is against EAFP, and this is how it is done elsewhere
| tnum = trigs.template_num | ||
| except AttributeError: | ||
| tnum = trigs['template_id'] | ||
|
|
||
| try: |
There was a problem hiding this comment.
This try/except is used a couple of times now. It would be good to be in a function. Codeclimate will probably complain
GarethCabournDavies
approved these changes
Aug 16, 2024
1 task
|
Please rebase on master to pick up #4855 and get the tests to pass. |
Co-authored-by: Gareth S Cabourn Davies <gareth.cabourndavies@ligo.org>
prayush
pushed a commit
to prayush/pycbc
that referenced
this pull request
Nov 21, 2024
* Have pycbc live mark flagged triggers instead of removing * Make stat usable in low-latency * Add command line argument for whether to use idq for reweighting * Add logging for iDQ flagged triggers * Fix bug when using ifo with no dq * Improve logic for getting ifo frm trigs * Update for compatibility with Gareth's stat reloading code * Modify how trig ifo is gotten and add debug statements * Use logging not print for debugging * logger not logging * Fix where tnum is set * Get rid of excess logging * Address Gareth's comments * Codeclimate * Apply suggestions from code review Co-authored-by: Gareth S Cabourn Davies <gareth.cabourndavies@ligo.org> --------- Co-authored-by: Gareth S Cabourn Davies <gareth.cabourndavies@ligo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard information about the request
This update allows the DQExpFitFgBgNormStatistic ranking statistic to be used in the low-latency PyCBC Live Search
This change primarily affects code used in the live search. No difference is expected in the Live search unless the DQExpFitFgBgNormStatistic is chosen. The same statistic code is also used in the offline search, but this update should not change the results of using the DQ stat in offline.
This change changes scientific output of the low-latency search if DQExpFitFgBgNormStatistic is selected as the ranking statistic.
Contents
While this change allows the DQExpFitFgBgNormStatistic to be used in low-latency, it does not include code changes needed to produce a new statistic file for that stat to use.
I plan to make a separate merge request in the next few days building on #4813 that will allow a new statistic file to be produced and read in daily.
Testing performed
Ran on the O3 replay MDC for a day