This repository has been archived by the owner on Aug 28, 2023. It is now read-only.
Publish types #11
Merged
Publish types #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, online results of arethetypeswrong: https://arethetypeswrong.github.io/?p=barcode-detector |
|
Thanks! |
|
Please test it out before releasing :D Or release a beta version NOT using latest tag, and I'll have a look in real life application! |
|
It releases automatically on merge. Don't worry, there are not many users of this package |
|
Oh, my! Well, I'm happy to say, it works just fine :D Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10
Sooo, it isn't perfect* - I've had problems configuring microbundle to output separate typings for CJS and ESM - but it's much better than it used to be. Here are outputs of arethetypeswrong (which actually tells a lot more, especially about module resolution):
Before:
After:
* - "isn't perfect" means that it has incorrect types for (rather rare) setup: Node.js >=16 + TypeScript + moduleResolution: "node16"/"nodenext". The question is, why would you need barcode-detector in Node.js.