Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

Publish types? #10

Closed
wojtekmaj opened this issue Aug 2, 2023 · 1 comment · Fixed by #11
Closed

Publish types? #10

wojtekmaj opened this issue Aug 2, 2023 · 1 comment · Fixed by #11

Comments

@wojtekmaj
Copy link
Contributor

Hi,
I see that this package is built with TypeScript, but does not ship with the types. @types/barcode-detector also does not exist. Would you consider publishing the types? Or, do you have any other recommendations?
TIA!
@gruhn
Copy link
Owner

gruhn commented Aug 2, 2023

I'm not super comfortable with TypeScript yet. You mind creating a PR? :)

@wojtekmaj wojtekmaj mentioned this issue Aug 2, 2023
Merged
@gruhn gruhn closed this as completed in #11 Aug 2, 2023
gruhn pushed a commit that referenced this issue Aug 2, 2023
@wojtekmaj
fix: publish types
21e83d3 
* Ignore *.tgz files
* Add extensions to import paths
* Add tsconfig.json to help microbundle decide what types to add
* Fix incorrect order of exports, add main types entry to package.json
* Don't include .github and test directories when packing

Closes #10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Publish types
2 participants
@wojtekmaj @gruhn