Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "stub: enable GRPC_CLIENT_CALL_REJECT_RUNNABLE in ThreadlessEx… #9067

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

YifeiZhuang
Copy link
Contributor

…ecutor shutdown (#9035)"

This reverts commit c53c3ad.

@YifeiZhuang YifeiZhuang requested a review from ejona86 April 6, 2022 20:23
@ejona86
Copy link
Member

ejona86 commented Apr 6, 2022

We're seeing RejectedExecutionExceptions caused by retries. We believe that if a retry starts a new stream at the same time as a cancellation, the cancellation wins a race and uses the executor before the new stream gets drained using that executor.

@YifeiZhuang YifeiZhuang merged commit 584622c into grpc:master Apr 6, 2022
@YifeiZhuang YifeiZhuang deleted the revert1 branch April 6, 2022 21:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants