-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stub: try enable GRPC_CLIENT_CALL_REJECT_RUNNABLE #9035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests look good. Although we still need to fix the cases in ClientCalls.blockingUnaryCall() where we shutdown the executor without waiting for the RPC closure.
you mean the incremental fix that we only shutdown the executor when RPC is successful (status is |
we discussed this. Only enable when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did dryrun tests on cl/435778399, enabling the flag, for multiple times, not seeing failures cases that are obviously caused by our change, so I am willing to give it a try. @ejona86 Wdyt?
Tests tended to be flaky. But the latest TAP train test signals that google3 might be ok if we enable it: