cherry-pick #1411 from master #1420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* template query params bug * add test case for invoke in process gateway * fix bazel error
* set rpcMethodName in request.Context * add test to check for rpcName pattern * change text in test * move rpcMethodName to annotateContext * remove rpcMethod from mux_test * remove rpcMethodName from handler * move rpcMethodKey to context
* standalone feature * replace trick * change default to false * go.mod newline at end of file * * generate examples * refactoring * add notes to readme.md * added BUILD.bazel * rebase to v2 * Update README.md Co-Authored-By: Johan Brandhorst <johan.brandhorst@gmail.com> * cut number of generated examples * tests for standalone echo * add missed file * magic * added tests: GoType, LoadWithStandalone, moved setting package alias from generator to registry Co-authored-by: Johan Brandhorst <johan.brandhorst@gmail.com>
* runtime/errors: remove 'error' field, use gRPC status instead
Signed-off-by: Stephan Renatus <srenatus@chef.io>
* internal/errors.proto: regenerate
Signed-off-by: Stephan Renatus <srenatus@chef.io>
* protoc-gen-swagger: use google.rpc.Status instead of .grpc.gateway.runtime.Error
Signed-off-by: Stephan Renatus <srenatus@chef.io>
* protoc-gen-swagger: rename AddStreamError -> AddErrorDefs, add to tests
There are probably better ways to write this in than calling
`AddErrorDefs` everywhere.
Signed-off-by: Stephan Renatus <srenatus@chef.io>
* run "bazel run :gazelle"
Signed-off-by: Stephan Renatus <srenatus@chef.io>
* rebuild all the things
Note: I've also run
find examples -name "*runtime_error*" -delete
before. It seems like those are not captured by any of the *clean make
targets.
Signed-off-by: Stephan Renatus <srenatus@chef.io>
* runtime/errors: fix comment, use status.Convert
Signed-off-by: Stephan Renatus <srenatus@chef.io>
* integration_test: port error status test to proto_error_test.go
Signed-off-by: Stephan Renatus <srenatus@chef.io>
This reduces the bus factor by moving control to the repo and away from my personal docker hub account.
As previously attempted on v1, so it shall be on v2. We want to minimize the public API surface to more easily allow changes that won't break users.
ADOPTERS.md is modeled after the OPA ADOPTERS.md: https://github.com/open-policy-agent/opa/blob/master/ADOPTERS.md
The token belongs to a user with no membership anywhere, and it is limited to only reading github packages.
Replace with internal copy of CamelCase
… parameters (#1267) * Added function nestedQueryParams with map[string] parameter for keeping track of and detecting circular references. Added test TestMessageToQueryParametersRecursive for testing gracefully handling of circular references between messages. See issue #1167 * Code-review change requests accepted * More missed circle references changed to cycle Fixes #1167
* httpbody in stream * httpbody contenttype in stream response * compare content type in test * Update examples/internal/integration/integration_test.go Co-authored-by: Johan Brandhorst <johan.brandhorst@gmail.com> * httpbody readme update Co-authored-by: Johan Brandhorst <johan.brandhorst@gmail.com>
json_names_for_fields defaults to true now
This was made internal, but it's actually used by the generated files.
* Adding docs about controlling http response status codes * PR changes based on review
* cherry-pick #1399 * remove extra * add missing test result change
This was requiring manual intervention and I thought I'd try to update it.
The last attempt failed at the push because the branch was implied. Use an explicit branch, and also use the renovate user for the commit.
* Add module generator option * Feedback from code review
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
#1411
Have you read the Contributing Guidelines?
Yes
Brief description of what is fixed or changed
cherry-pick #1411 from master
Other comments