Add module generator option #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add module generator option * Feedback from code review
johanbrandhorst
approved these changes
May 27, 2020
Codecov Report
@@ Coverage Diff @@
## v2 #1409 +/- ##
==========================================
+ Coverage 58.82% 58.91% +0.09%
==========================================
Files 32 32
Lines 3891 3907 +16
==========================================
+ Hits 2289 2302 +13
- Misses 1349 1351 +2
- Partials 253 254 +1
Continue to review full report at Codecov.
|
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #1400 on v2 branch