Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type assertion bug caused by non-existent k8s_surge_node_count #212

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Fix type assertion bug caused by non-existent k8s_surge_node_count #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions gridscale/resource_gridscale_k8s.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,9 @@ func resourceGridscaleK8sRead(d *schema.ResourceData, meta interface{}) error {
"storage_type": props.Parameters["k8s_worker_node_storage_type"],
}
// Surge node feature is enable if k8s_surge_node_count > 0
surgeNodeCount := props.Parameters["k8s_surge_node_count"].(float64)
nodePool["surge_node"] = surgeNodeCount > 0
if surgeNodeCount, ok := props.Parameters["k8s_surge_node_count"].(float64); ok {
nodePool["surge_node"] = surgeNodeCount > 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the value of nodePool["surge_node"] if k8s_surge_node_count was not? In other words, the condition is failed @nvthongswansea

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itakouna if the condition is not met, the default value (true) of the surge_node will be set.

}

nodePoolList = append(nodePoolList, nodePool)
if err = d.Set("node_pool", nodePoolList); err != nil {
Expand Down