Fix type assertion bug caused by non-existent k8s_surge_node_count #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itakouna
reviewed
Oct 18, 2022
| surgeNodeCount := props.Parameters["k8s_surge_node_count"].(float64) | ||
| nodePool["surge_node"] = surgeNodeCount > 0 | ||
| if surgeNodeCount, ok := props.Parameters["k8s_surge_node_count"].(float64); ok { | ||
| nodePool["surge_node"] = surgeNodeCount > 0 |
There was a problem hiding this comment.
what's the value of nodePool["surge_node"] if k8s_surge_node_count was not? In other words, the condition is failed @nvthongswansea
There was a problem hiding this comment.
@itakouna if the condition is not met, the default value (true) of the surge_node will be set.
itakouna
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
k8s_surge_node_countcan be asserted intofloat64. If so, set the resource parametersurge_node; o.w, don't set that parameter.