Ensure quantile forests give consistent estimates across platforms. #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now include a tie-breaker while sorting the list of sample IDs and outcomes. Without the tie-breaker, the sort could produce a different element ordering across different runs of the algorithm.
jtibshirani
added a commit
that referenced
this pull request
Aug 21, 2019
Previously, the C++ characterization tests only passed when using clang because of differences in the way random numbers are generated across platforms. Because we build on a couple different platforms, we had to disable these tests in CI. Now that we've added platform-independent random number generation in #469 and #492, we can enable the characterization tests.
erikcs
added a commit
to erikcs/grf
that referenced
this pull request
Aug 22, 2019
* master: Update boosting and bart implementations in simulations (grf-labs#487) Run the characterization tests in CI. (grf-labs#485) fix typo (grf-labs#491) Ensure quantile forests give consistent estimates across platforms. (grf-labs#492) Add src/RcppExports.cpp to version control (grf-labs#489)
davidahirshberg
pushed a commit
to davidahirshberg/grf
that referenced
this pull request
Dec 6, 2019
…rf-labs#492) We now include a tie-breaker while sorting the list of sample IDs and outcomes. Without the tie-breaker, the sort could produce a different element ordering across different runs of the algorithm.
davidahirshberg
pushed a commit
to davidahirshberg/grf
that referenced
this pull request
Dec 6, 2019
Previously, the C++ characterization tests only passed when using clang because of differences in the way random numbers are generated across platforms. Because we build on a couple different platforms, we had to disable these tests in CI. Now that we've added platform-independent random number generation in grf-labs#469 and grf-labs#492, we can enable the characterization tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now include a tie-breaker while sorting the list of sample IDs and outcomes.
Without the tie-breaker, the sort could produce a different element ordering
across different runs of the algorithm.