Skip to content

Commit

Permalink
Run the characterization tests in CI. (grf-labs#485)
Browse files Browse the repository at this point in the history
Previously, the C++ characterization tests only passed when using clang because
of differences in the way random numbers are generated across platforms.
Because we build on a couple different platforms, we had to disable these tests
in CI.

Now that we've added platform-independent random number generation in grf-labs#469 and
grf-labs#492, we can enable the characterization tests.
  • Loading branch information
jtibshirani authored and davidahirshberg committed Dec 6, 2019
1 parent 250601b commit 6d821d1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ matrix:
- mkdir build && cd build
- cmake -DCMAKE_CXX_COMPILER=$COMPILER .. && make
- cd ..
- valgrind --leak-check=full --error-exitcode=1 ./build/grf exclude:[characterization]
- valgrind --leak-check=full --error-exitcode=1 ./build/grf

- name: "core grf C++: clang"
compiler: clang
Expand All @@ -59,7 +59,7 @@ matrix:
- mkdir build && cd build
- cmake -DCMAKE_CXX_COMPILER=$COMPILER .. && make
- cd ..
- valgrind --leak-check=full --error-exitcode=1 ./build/grf exclude:[characterization]
- valgrind --leak-check=full --error-exitcode=1 ./build/grf

- name: "grf R package"
before_install:
Expand Down

0 comments on commit 6d821d1

Please sign in to comment.