Change: Add additional valid URLs to script_xref() URL test. #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
1 task
66a5d61 to
7b9b5f8
Compare
mbrinkhoff
approved these changes
Sep 25, 2023
7b9b5f8 to
9de82a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds the valid URLs which i have identified / collected previously in:
python-validators/validators#296 (comment)
Why
To catch issues caused by dependency updates earlier (like happened via #594 and reverted afterwards via #609). This is important especially as we only had a very basic URL
http://www.example.comin the current test.References
None directly
Checklist