-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Python 3.9+ and update dependencies #594
Conversation
Conventional Commits Report
🚀 Conventional commits found. |
3be119a
to
cb67145
Compare
TODO: After approval and right before merging this, update the branch protection rules to make the new Python 3.11 mandatory and drop Python 3.7 and 3.8 from the required checks. |
You may want to switch from ruff is ALOT faster then pylint! |
Björn already pitched it to me :D We'll definitely consider it, but preferrebly in another PR to the the domain small |
cb67145
to
8d927df
Compare
Codecov Report
@@ Coverage Diff @@
## main #594 +/- ##
=======================================
Coverage 78.20% 78.21%
=======================================
Files 80 80
Lines 2698 2699 +1
Branches 571 571
=======================================
+ Hits 2110 2111 +1
Misses 441 441
Partials 147 147
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Dropped the checks for Python 3.7 & 3.8 and added the one for Python 3.11 in the branch protection rules. |
It seems the update of the
And update from 0.21.2 to 0.22.0 seems currently pending via: might solve this as it includes fixes from / for: |
It seems with the version bump from 0.21.2 to 0.22.0 the amount of reported "invalid" URLs which seems to be valid have dropped only from I will raise a follow-up issue at https://github.com/python-validators/validators to see if these can be fixed / solved in the package. |
Seems some one was faster and raised python-validators/validators#296, i have added examples from our cases there now. #609 downgraded the package to version 0.20.0 now as an intermediate solution until the affected package received an update / fix. |
#624 added now a few additional valid URLs to our unit tests so that such issues due to dependency updates are found earlier. |
What
This PR bumps the minimum required Python version to 3.9 or higher and updates this projects dependencies.
Why
pontos
requires Python 3.9+References
Checklist