Introduce version checking and fix YAML lists #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
kontsevoy
approved these changes
Feb 7, 2018
|
retest this please |
r0mant
approved these changes
Feb 7, 2018
lib/client/api.go
Outdated
| @@ -190,6 +190,10 @@ type Config struct { | |||
|
|
|||
| // AuthConnector is the name of the authentication connector to use. | |||
| AuthConnector string | |||
|
|
|||
| // CheckVersions will check that client version is compatible | |||
| // to auth server version when connecting. | |||
89f2491 to
27ce2e1
Compare
russjones
approved these changes
Feb 7, 2018
|
retest this please |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1663, #1665
This commit fixes a couple of issues with tsh and tctl:
tsh now check the version of the server and prints error
if tsh is newer version than the server.
tctl did not work properly when yaml file contained
multiple resources in a list