Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating multiple resources does not work with yaml lists #1663

Closed
klizhentas opened this issue Feb 6, 2018 · 0 comments · Fixed by #1665
Closed

Creating multiple resources does not work with yaml lists #1663

klizhentas opened this issue Feb 6, 2018 · 0 comments · Fixed by #1665
Assignees
@klizhentas
Labels
bug
Milestone
2.5.0 "New York"

Comments

@klizhentas
Copy link
Contributor

What happened:

tctl create -f resources.yaml only created the first resource in the list

What you expected to happen:

All resources should be created

How to reproduce it (as minimally and precisely as possible):

tctl create -f list.yaml

resource a
---
resource b

Environment:

  • Teleport version (use teleport version):
  • Tsh version (use tsh version):
    all versions
  • OS (e.g. from /etc/os-release):

Bug is on this line:

https://github.com/gravitational/teleport/blob/master/tool/tctl/common/resource_command.go#L171

only return if error here
@klizhentas klizhentas added the bug label Feb 6, 2018
@klizhentas klizhentas added this to the 2.5.0 "New York" milestone Feb 6, 2018
@klizhentas klizhentas self-assigned this Feb 6, 2018
@klizhentas klizhentas changed the title Createing multiple resources does not work with yaml lists Creating multiple resources does not work with yaml lists Feb 6, 2018
@klizhentas klizhentas mentioned this issue Feb 7, 2018
Merged
klizhentas added a commit that referenced this issue Feb 7, 2018
@klizhentas
Introduce version checking and fix YAML lists
27ce2e1 
Fixes #1663, #1665

This commit fixes a couple of issues with tsh and tctl:

* tsh now check the version of the server and prints error
if tsh is newer version than the server.

* tctl did not work properly when yaml file contained
multiple resources in a list
@klizhentas klizhentas mentioned this issue Feb 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klizhentas klizhentas

Labels
bug
Projects
None yet
Milestone
2.5.0 "New York"
Development

Successfully merging a pull request may close this issue.

Introduce version checking and fix YAML lists gravitational/teleport
1 participant
@klizhentas