Skip to content

Commit

Permalink
Merge pull request #1003 from gravitational/rjones/http-proxy
Browse files Browse the repository at this point in the history
HTTP CONNECT Tunneling
  • Loading branch information
russjones authored May 25, 2017
2 parents 14cf169 + 2117306 commit bedd6db
Show file tree
Hide file tree
Showing 6 changed files with 576 additions and 9 deletions.
8 changes: 8 additions & 0 deletions constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,14 @@ const (
SSHSessionID = "SSH_SESSION_ID"
)

const (
// HTTPSProxy is an environment variable pointing to a HTTPS proxy.
HTTPSProxy = "HTTPS_PROXY"

// HTTPProxy is an environment variable pointing to a HTTP proxy.
HTTPProxy = "HTTP_PROXY"
)

const (
// TOTPValidityPeriod is the number of seconds a TOTP token is valid.
TOTPValidityPeriod uint = 30
Expand Down
21 changes: 21 additions & 0 deletions docs/2.0/admin-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -909,6 +909,27 @@ $ ssh-keygen -L -f ~/.tsh/keys/localhost/jsmith.cert
permit-pty
```
### HTTP CONNECT Tunneling
Some networks funnel all connections through a proxy server where they can be
audited and access control rules applied. For these scenarios Teleport supports
HTTP CONNECT tunneling.
To use HTTP CONNECT tunneling, simply set either the `HTTPS_PROXY` or
`HTTP_PROXY` environment variables and when Teleport builds and establishes the
reverse tunnel to the main cluster, it will funnel all traffic though the proxy.
Specifically Teleport will tunnel ports `3024` (SSH, reverse tunnel) and `3080`
(HTTPS, establishing trust) through the proxy.
The value of `HTTPS_PROXY` or `HTTP_PROXY` should be in the format
`scheme://host:port` where scheme is either `https` or `http`. If the
value is `host:port`, Teleport will prepend `http`.
!!! tip "Note":
`localhost` and `127.0.0.1` are invalid values for the proxy host. If for
some reason your proxy runs locally, you'll need to provide some other DNS
name or a private IP address for it.
## Using Teleport with OpenSSH
Teleport is a standards-compliant SSH proxy and it can work in environments with
Expand Down
17 changes: 9 additions & 8 deletions lib/auth/trustedcluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
"net/url"

"github.com/gravitational/teleport"
"github.com/gravitational/teleport/lib/defaults"
"github.com/gravitational/teleport/lib/httplib"
"github.com/gravitational/teleport/lib/services"

Expand Down Expand Up @@ -219,14 +218,16 @@ func (s *AuthServer) sendValidateRequestToProxy(host string, validateRequest *Va
log.Warn("InsecureSkipVerify used to communicate with proxy.")
log.Warn("Make sure you intend to run Teleport in debug mode.")

// get the default transport (so we can get the proxy from environment)
// but disable tls certificate checking.
tr, ok := http.DefaultTransport.(*http.Transport)
if !ok {
return nil, trace.BadParameter("unable to get default transport")
}
tr.TLSClientConfig = &tls.Config{InsecureSkipVerify: true}

insecureWebClient := &http.Client{
Transport: &http.Transport{
TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
// IdleConnTimeout defines the maximum amount of time before idle connections
// are closed. Leaving this unset will lead to connections open forever and
// will cause memory leaks in a long running process
IdleConnTimeout: defaults.HTTPIdleTimeout,
},
Transport: tr,
}
opts = append(opts, roundtrip.HTTPClient(insecureWebClient))
}
Expand Down
5 changes: 4 additions & 1 deletion lib/reversetunnel/agent.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import (
"github.com/gravitational/teleport/lib/services"
"github.com/gravitational/teleport/lib/sshutils"
"github.com/gravitational/teleport/lib/utils"
"github.com/gravitational/teleport/lib/utils/proxy"

log "github.com/Sirupsen/logrus"
"github.com/gravitational/trace"
Expand Down Expand Up @@ -153,7 +154,9 @@ func (a *Agent) connect() (conn *ssh.Client, err error) {
return nil, trace.BadParameter("reverse tunnel cannot be created: target address is empty")
}
for _, authMethod := range a.authMethods {
conn, err = ssh.Dial(a.addr.AddrNetwork, a.addr.Addr, &ssh.ClientConfig{
// if http_proxy is set, dial through the proxy
dialer := proxy.DialerFromEnvironment()
conn, err = dialer.Dial(a.addr.AddrNetwork, a.addr.Addr, &ssh.ClientConfig{
User: a.clientName,
Auth: []ssh.AuthMethod{authMethod},
HostKeyCallback: a.hostKeyCallback,
Expand Down
162 changes: 162 additions & 0 deletions lib/utils/proxy/proxy.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,162 @@
/*
Copyright 2017 Gravitational, Inc.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package proxy

import (
"bufio"
"context"
"net"
"net/http"
"net/url"
"os"
"strings"

"github.com/gravitational/teleport"
"github.com/gravitational/trace"

"golang.org/x/crypto/ssh"

log "github.com/Sirupsen/logrus"
)

// A Dialer is a means for a client to establish a SSH connection.
type Dialer interface {
// Dial establishes a client connection to a SSH server.
Dial(network string, addr string, config *ssh.ClientConfig) (*ssh.Client, error)
}

type directDial struct{}

// Dial calls ssh.Dial directly.
func (d directDial) Dial(network string, addr string, config *ssh.ClientConfig) (*ssh.Client, error) {
return ssh.Dial(network, addr, config)
}

type proxyDial struct {
proxyHost string
}

// Dial first connects to a proxy, then uses the connection to establish a new
// SSH connection.
func (d proxyDial) Dial(network string, addr string, config *ssh.ClientConfig) (*ssh.Client, error) {
// build a proxy connection first
pconn, err := dialProxy(d.proxyHost, addr)
if err != nil {
return nil, trace.Wrap(err)
}

// do the same as ssh.Dial but pass in proxy connection
c, chans, reqs, err := ssh.NewClientConn(pconn, addr, config)
if err != nil {
return nil, trace.Wrap(err)
}
return ssh.NewClient(c, chans, reqs), nil
}

// DialerFromEnvironment returns a Dial function. If the https_proxy or http_proxy
// environment variable are set, it returns a function that will dial through
// said proxy server. If neither variable is set, it will connect to the SSH
// server directly.
func DialerFromEnvironment() Dialer {
// try and get proxy addr from the environment
proxyAddr := getProxyAddress()

// if no proxy settings are in environment return regular ssh dialer,
// otherwise return a proxy dialer
if proxyAddr == "" {
log.Debugf("[HTTP PROXY] No proxy set in environment, returning direct dialer.")
return directDial{}
}
log.Debugf("[HTTP PROXY] Found proxy %q in environment, returning proxy dialer.", proxyAddr)
return proxyDial{proxyHost: proxyAddr}
}

func dialProxy(proxyAddr string, addr string) (net.Conn, error) {
ctx := context.Background()

var d net.Dialer
conn, err := d.DialContext(ctx, "tcp", proxyAddr)
if err != nil {
log.Warnf("[HTTP PROXY] Unable to dial to proxy: %v: %v", proxyAddr, err)
return nil, trace.ConvertSystemError(err)
}

connectReq := &http.Request{
Method: http.MethodConnect,
URL: &url.URL{Opaque: addr},
Host: addr,
Header: make(http.Header),
}
err = connectReq.Write(conn)
if err != nil {
log.Warnf("[HTTP PROXY] Unable to write to proxy: %v", err)
return nil, trace.Wrap(err)
}

br := bufio.NewReader(conn)
resp, err := http.ReadResponse(br, connectReq)
if err != nil {
conn.Close()
log.Warnf("[HTTP PROXY] Unable to read response: %v", err)
return nil, trace.Wrap(err)
}
if resp.StatusCode != http.StatusOK {
f := strings.SplitN(resp.Status, " ", 2)
conn.Close()
return nil, trace.BadParameter("Unable to proxy connection, StatusCode %v: %v", resp.StatusCode, f[1])
}

return conn, nil
}

func getProxyAddress() string {
envs := []string{
teleport.HTTPSProxy,
strings.ToLower(teleport.HTTPSProxy),
teleport.HTTPProxy,
strings.ToLower(teleport.HTTPProxy),
}

for _, v := range envs {
addr := os.Getenv(v)
if addr != "" {
proxyaddr, err := parse(addr)
if err != nil {
log.Debugf("[HTTP PROXY] Unable to parse environment variable %q: %q.", v, addr)
continue
}
log.Debugf("[HTTP PROXY] Successfully parsed environment variable %q: %q to %q", v, addr, proxyaddr)
return proxyaddr
}
}

log.Debugf("[HTTP PROXY] No valid environment variables found.")
return ""
}

// parse will extract the host:port of the proxy to dial to. If the
// value is not prefixed by "http", then it will prepend "http" and try.
func parse(addr string) (string, error) {
proxyurl, err := url.Parse(addr)
if err != nil || !strings.HasPrefix(proxyurl.Scheme, "http") {
proxyurl, err = url.Parse("http://" + addr)
if err != nil {
return "", trace.Wrap(err)
}
}

return proxyurl.Host, nil
}
Loading

0 comments on commit bedd6db

Please sign in to comment.