HTTP CONNECT Tunneling #1003
Merged
HTTP CONNECT Tunneling #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f83f100 to
008b849
Compare
klizhentas
reviewed
May 18, 2017
docs/2.0/admin-guide.md
Outdated
| audited and access control rules applied. For these scenarios Teleport supports | ||
| HTTP CONNECT tunneling. | ||
|
|
||
| To use HTTP CONNECT tunneling, simply set either the `https_proxy` or |
There was a problem hiding this comment.
are those standard names for env variables? generally linux env vars are using HTTPS_PROXY upper case notations, what are others are using?
There was a problem hiding this comment.
Yeah, I was confused by that as well, it looks like Go assumes either all caps or all lower case. From the docs:
ProxyFromEnvironment returns the URL of the proxy to use for a given
request, as indicated by the environment variables HTTP_PROXY, HTTPS_PROXY
and NO_PROXY (or the lowercase versions thereof). HTTPS_PROXY takes
precedence over HTTP_PROXY for https requests.
In code: https://github.com/golang/go/blob/master/src/net/http/transport.go#L550-L560
I'll adjust this.
lib/utils/proxy/proxy.go
Outdated
| // build a proxy connection first | ||
| pconn, err := dialProxy(d.proxyHost, addr) | ||
| if err != nil { | ||
| return nil, err |
lib/utils/proxy/proxy.go
Outdated
| Host: addr, | ||
| Header: make(http.Header), | ||
| } | ||
| connectReq.Write(conn) |
lib/utils/proxy/proxy.go
Outdated
| var d net.Dialer | ||
| conn, err := d.DialContext(ctx, "tcp", proxyAddr) | ||
| if err != nil { | ||
| return nil, trace.Wrap(err) |
There was a problem hiding this comment.
trace.ConvertSystemError instead
f74bfd3 to
dbacf17
Compare
dbacf17 to
2117306
Compare
hatched
pushed a commit
to hatched/teleport-merge
that referenced
this pull request
Nov 30, 2022
hatched
pushed a commit
that referenced
this pull request
Dec 20, 2022
hatched
pushed a commit
that referenced
this pull request
Feb 1, 2023
* `SharedDirectoryInfoResponse` (#996) * `SharedDirectoryListRequest` (#999) * `SharedDirectoryListResponse` (#1000) * `SharedDirectoryReadRequest` (#1003) * `SharedDirectoryReadResponse` (#1005) * `SharedDirectoryWriteRequest` (#1007) * `SharedDirectoryWriteResponse` (#1008) * Tidy up `sharedDirectoryManager` (#1010) * `SharedDirectoryMoveRequest` (#1045) * `SharedDirectoryMoveResponse` (#1074) * `SharedDirectoryCreateRequest` and `SharedDirectoryCreateResponse` (#1090) * SharedDirectoryDeleteRequest and SharedDirectoryDeleteResponse (#1096) * Add warning dialog for unsupported browsers for directory sharing (#1110) * updates yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As covered in #860, at the moment Teleport does not support HTTP CONNECT tunneling. This PR adds support for HTTP CONNECT tunneling for Trusted Clusters.
Implementation
proxyhas been added underutils.proxypackage exposes a single functionDialerFromEnvironment.DialerFromEnvironmentchecks ifhttps_proxyorhttp_proxyare set, if either are it dials to the proxy and then establishes a SSH connection, or directly establishes a SSH connection.ssh.Dialdirectly we extract a dial from the environment and then establish the reverse tunnel.Related Issues
Fixes #860