refactor apps.mobile_app.tasks into individual task files #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
commented
Aug 28, 2023
|
|
||
|
|
||
| @shared_dedicated_queue_retry_task(autoretry_for=(Exception,), retry_backoff=True, max_retries=MAX_RETRIES) | ||
| def notify_user_async(user_pk, alert_group_pk, notification_policy_pk, critical): |
There was a problem hiding this comment.
it would make sense to rename this task to something more descriptive (ex. notify_user_about_alert_group).
What is the order of operations for renaming a task? Can I simply rename it, leave the old task routing definition in place + add the new one, then remove the old one in a future release?
There was a problem hiding this comment.
I would create the new one, add it to routing and call wherever it's needed and leave the old, just change its code to call the new task. Then the old one can be removed in a future release.
Ferril
approved these changes
Aug 29, 2023
3 tasks
joeyorlando
added a commit
that referenced
this pull request
Aug 29, 2023
…roup (#2900) # What this PR does Follow up to #2888, rename `notify_user_async` celery task to `notify_user_about_new_alert_group`. ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Closes #2722
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)