Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor engine/apps/mobile_app/tasks.py into smaller individual task files #2722

Closed
joeyorlando opened this issue Aug 2, 2023 · 1 comment · Fixed by #2888
Closed

Refactor engine/apps/mobile_app/tasks.py into smaller individual task files #2722

joeyorlando opened this issue Aug 2, 2023 · 1 comment · Fixed by #2888
Assignees
@joeyorlando
Labels
feature request New feature or request more info needed

Comments

@joeyorlando
Copy link
Contributor

What would you like to see!

The file is starting to get very large. We added a todo note in #2717 to refactor this, this issue tracks that.

Deliverables

  • Refactor engine/apps/mobile_app/tasks.py into a folder engine/apps/mobile_app/tasks/ which contains one file per push notification that we are sending out. Some methods can possibly be extracted out into a common "utils" file.

Product Area

Other

Anything else to add?

No response
@joeyorlando joeyorlando added the feature request New feature or request label Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

The current version of Grafana OnCall, at the time this issue was opened, is v1.3.21. If your issue pertains to an older version of Grafana OnCall, please be sure to list it in the PR description. Thank you 😄!

@joeyorlando joeyorlando mentioned this issue Aug 2, 2023
Merged
3 tasks
@joeyorlando joeyorlando self-assigned this Aug 28, 2023
@joeyorlando joeyorlando mentioned this issue Aug 28, 2023
Merged
3 tasks
joeyorlando added a commit that referenced this issue Aug 29, 2023
@joeyorlando
refactor apps.mobile_app.tasks into individual task files (#2888)
cba4ccb 
# What this PR does

Closes #2722 

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeyorlando joeyorlando

Labels
feature request New feature or request more info needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor apps.mobile_app.tasks into individual task files grafana/oncall
1 participant
@joeyorlando