Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift swap request push notification follow-ups #2805

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Shift swap request push notification follow-ups #2805

merged 5 commits into from
Aug 16, 2023

Conversation

vstpme
Copy link
Member

@vstpme vstpme commented Aug 16, 2023 •
edited
Loading

What this PR does

Adds SSR push notification follow-ups (similar to #2798)

Which issue(s) this PR fixes

#2679

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@vstpme vstpme added the pr:no public docs Added to a PR that does not require public documentation updates label Aug 16, 2023
@vstpme vstpme marked this pull request as ready for review August 16, 2023 13:22
@vstpme vstpme requested a review from a team August 16, 2023 13:22
joeyorlando
joeyorlando approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just one minor comment

engine/apps/mobile_app/tasks.py Outdated Show resolved Hide resolved
@vstpme vstpme enabled auto-merge August 16, 2023 15:57
@vstpme vstpme added this pull request to the merge queue Aug 16, 2023
Merged via the queue into dev with commit a2390a9 Aug 16, 2023
@vstpme vstpme deleted the vadimkerr/ssr-followups-mobile-app branch August 16, 2023 16:06
@vstpme vstpme mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyorlando joeyorlando joeyorlando approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstpme @joeyorlando